fix(test): cover QueryExpr::TimeShift in the netflow corpus visitor - #113
Merged
Merged
Conversation
`main` does not compile: `cargo test -p asap-frontend-sql --test netflow` fails with E0004, non-exhaustive patterns. PR #106 added `QueryExpr::TimeShift` (the `offset` / `@` lowering for #40). PR #107 added the netflow corpus, whose `visit()` matches `QueryExpr` exhaustively, and was branched before #106 landed. Each PR was green on its own base; neither was rebased, so the breakage only appeared once both were on `main`. `TimeShift` is a single-child pass-through, so it joins the existing recurse-into-`child` arm. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maincurrently does not compile:Cause
#106 added
QueryExpr::TimeShift(theoffset/@lowering for #40). #107 added the netflow corpus, whosevisit()matchesQueryExprexhaustively, and was branched before #106 landed. Each PR was green against its own base; neither was rebased before merge, so the conflict only materialised once both were onmain. It is a semantic conflict, not a textual one, so git merged it cleanly.Fix
TimeShift { shift, child }is a single-child pass-through, so it joins the existing recurse-into-childarm.Verification
🤖 Generated with Claude Code