test: add SQL netflow corpus - #107
Merged
Merged
Conversation
zzylol
force-pushed
the
test/asapquery-sql-corpus
branch
from
July 7, 2026 11:44
329ceae to
d58ef68
Compare
zzylol
changed the title
Contributor
Author
Move the netflow SQL corpus test into an `asapquery/` domain folder so it mirrors the `data_quality_check/` layout: the test `.rs` lives inside the domain folder alongside its `data/` subdirectory, declared explicitly in Cargo.toml since Cargo only auto-discovers `.rs` files directly in `tests/`. - tests/asapquery_sql_netflow.rs -> tests/asapquery/netflow.rs - include_str! path -> "data/netflow.sql" - add [[test]] name = "asapquery_netflow" Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@milindsrivastava1997 Added you as a reviewer. |
milindsrivastava1997
approved these changes
Jul 7, 2026
Collaborator
No need I think. |
Rename the domain folder and all identifiers to use only "sql" and "netflow" terms. - tests/asapquery/netflow.rs -> tests/netflow/netflow.rs - [[test]] name asapquery_netflow -> netflow - test fn / doc comments drop the ASAPQuery references Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
zzylol
changed the title
zzylol
added a commit
that referenced
this pull request
Jul 9, 2026
…113) `main` does not compile: `cargo test -p asap-frontend-sql --test netflow` fails with E0004, non-exhaustive patterns. PR #106 added `QueryExpr::TimeShift` (the `offset` / `@` lowering for #40). PR #107 added the netflow corpus, whose `visit()` matches `QueryExpr` exhaustively, and was branched before #106 landed. Each PR was green on its own base; neither was rebased, so the breakage only appeared once both were on `main`. `TimeShift` is a single-child pass-through, so it joins the existing recurse-into-`child` arm. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/netflow/domain folder (test.rs+data/), mirroringtests/data_quality_check/Tests
cargo test -p asap-frontend-sql