feat(mvp): validate versioned PhysicalPlan contract in ASAPCollector - #585
Merged
Merged
Conversation
zzylol
force-pushed
the
feat/physical-plan-mvp-validation
branch
from
September 3, 2026 14:36
2cb8ca8 to
e3749c4
Compare
Contributor
Author
|
Updated after ASAPCollector docs PR #586: rebased onto current main and added strict consumption of Planner-owned abstract_window_framework plus backend-owned window_implementation_id/pane_secs/state_layout. The MVP accepts only tumbling + equal anchored panes + anchored-pane-v1 and atomically rejects unsupported or mismatched realizations in both Rust and Go. |
zzylol
force-pushed
the
feat/physical-plan-mvp-validation
branch
from
September 3, 2026 20:22
334579c to
eca666f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CollectorPlangenerations withplan_id, globally monotonicplan_version, activation/expiry, backend compatibility, exact materialization fingerprints, and one-to-oneTransmissionRulesactivation_unix_ms, then validate every runtime target and cut over all shards as one boundary; reportAPPLIEDonly after the whole generation installs, otherwise reportFAILEDwindow_implementation_idvalues and align Go/Rust fail-closed behavior for exactsumBackend dependency
This validates the PhysicalPlan stack in ASAPQuery-backend PRs #472, #474, #475, #476, and #477. PR #477 includes atomic batch preflight, concrete-series delta lineage, cross-window sequencing, and STAGED activation synchronization found during this integration.
Validation
cargo fmt --manifest-path asap-precompute-rs/Cargo.toml -- --checkcargo clippy --manifest-path asap-precompute-rs/Cargo.toml --all-features --all-targets(passes with existing warnings)cargo test --manifest-path asap-precompute-rs/Cargo.toml --all-features: 151 tests passed(cd asap-precompute-go && go test ./...): passed(cd opentelemetry-collector-contrib-patch/processor/asapedgeprocessor && go test ./...): passedsketchlib-gocommit148643fgit diff --checkFail-closed boundaries
The consumer rejects unsupported/unknown window realizations, exact
sumuntil both runtime projections share its wire contract, keyed CMS heap serving, anisotropic GOS, non-integral delta thresholds, mismatched cadence/encoding/producer rules, stale or expired generations, global version resets across plan IDs, unknown schema fields, and any runtime executor whose window/family/algorithm parameters do not match the physical plan.The current processor registry has one executor slot per metric name. Two materializations for the same metric therefore fail closed instead of being silently collapsed; supporting them requires the follow-up registry refactor to key executors by materialization fingerprint.
HTTP 2xx / gRPC OK remains the delivery acknowledgement, with no second application ACK or sender WAL.
asap_edgeassigns identity before exporter handoff; transport retry/persistence is the configured Collector exporter's responsibility.