Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions asap-precompute-go/controlchannel/opamp.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import (
// OpAmpChannel is the OpAMP-backed ControlChannel implementation.
//
// TODO(phase-5): wire real OpAMP client (github.com/open-telemetry/
// opamp-go/client) per docs/adr/adr-0003-adapter-trait-and-control-channel.md;
// today this is an interface-satisfying stub so the controller side
// opamp-go/client); today this is an interface-satisfying stub so the
// controller side
// can compile against the trait without forcing a transitive
// opamp-go dep into Phase 2.
type OpAmpChannel struct {
Expand Down
2 changes: 1 addition & 1 deletion asap-precompute-go/monitor/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ type monitorState struct {
// obsCount is the number of observations admitted for this monitor since
// the current epoch began. It is the edge's observed items/window (rate)
// reported to the coordinator so it can size this edge's sampling
// probability (AllocateSampleRates). Reset to 0 at each epoch boundary.
// probability via the whole-sketch ε-floor. Reset to 0 at each epoch boundary.
obsCount uint64
// grantedSampleP is the coordinator-allocated distributed-NitroSketch
// update-sampling probability for this monitor's agg. 0 (unset) ⇒ no
Expand Down
8 changes: 5 additions & 3 deletions asap-precompute-go/monitor/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,9 @@ type Report struct {
Round uint64
Seq uint64
// Rate is the edge's observed item count for this monitor over the current
// epoch (items/window). The coordinator feeds it into AllocateSampleRates
// (p_i ∝ √(f_i/rate_i)) to size this edge's distributed-NitroSketch sampling
// epoch (items/window). The coordinator feeds it into the whole-sketch
// ε-floor (p_i = 1/(1+ε²·rate_i); see data_plane allocate_p /
// epsilon_sample_floor) to size this edge's distributed-NitroSketch sampling
// probability. 0 (unset) ⇒ the coordinator falls back to an unsampled
// allocation for this edge.
Rate float64
Expand All @@ -136,7 +137,8 @@ type Grant struct {
LocalSlack float64
WindowStartMs uint64
// SampleP is the distributed-NitroSketch update-sampling probability the
// coordinator allocates this edge (AllocateSampleRates: p_i ∝ √(f_i/rate_i)).
// coordinator allocates this edge via the whole-sketch ε-floor
// (p_i = 1/(1+ε²·rate_i); see data_plane allocate_p / epsilon_sample_floor).
// 0 (unset) ⇒ no sampling grant (p=1). The edge applies it via WithSampleP on
// the metric's sketch wrapper at the next EpochReset (never mid-window, so
// both merge operands share one p). Orthogonal to LocalSlack (which governs
Expand Down
3 changes: 1 addition & 2 deletions asap-precompute-go/observation.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Package precompute is the host-neutral edge precompute runtime
// described in `docs/design-asap-edge-framework.md` §6 and pinned
// by `docs/adr/adr-0002-extract-precompute-runtime.md`.
// described in `docs/design-asap-edge-framework.md` §6.
//
// This package owns the windowing, snapshot caching, and delta
// encoding runtime logic that today lives inside each OTel
Expand Down
168 changes: 0 additions & 168 deletions asap-precompute-go/otlpfilter/README.md

This file was deleted.

Loading