Conversation
…pfilter wire filter) The sampling MECHANISM. Each datapoint's keep/drop is a pure hash of (seed=SeedForMetric(name), occurrence=ts_ms, row) — R(x)=∅ iff no row admits, prob (1-p)^d. The otlpfilter drops raw OTLP bytes pre-decode; the SDK sketch aggregators re-evaluate the identical per-row decision on survivors and rescale by 1/p. Two views of ONE decision, so they agree without shared RNG. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Superseded by SDK-side single-decision sampling: row admission decides exactly once, upstream of serialization, so no downstream stage independently re-derives it via a reproducible hash. Delete the whole otlpfilter wire-filter package. SDK aggregators (countsketch.go, countminsketch.go) revert to GeometricSampler — same per-series, window-salted seed, same RowSampler interface, call sites unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Superseded by |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1/3 of the old #510 (per-cell pipeline), now that #509 (removals) is merged.
The sampling mechanism. Each datapoint's keep/drop is a pure hash of
(seed=SeedForMetric(name), occurrence=ts_ms, row)— dropped iff no row admits (theR(x)=∅event, prob(1−p)^d).otlpfilterdrops raw OTLP bytes pre-decode; the SDK aggregators re-evaluate the identical per-row decision on survivors and rescale by1/p. Two views of ONE decision → agree with no shared RNG, no locks, idempotent.opentelemetry-go-patch/sdk/metric/*— source-side sampling in the SDK aggregators.asap-precompute-go/otlpfilter/*— pre-decode wire filter (self-contained; sketchlib-go/common only).Stacked: → #512 (monitor) → #513 (integration) → #511 (eval).
🤖 Generated with Claude Code