Conversation
Wires sampling (#508b-1) + the monitor grant (#508b-2) into the edge: per-cell sketch delta (Go sketches + asap-precompute-rs), the window threading each item's consistent-sampling identity + granted p into the wrapper, the fused asap_edge processor + OCB manifests, and the otel-app sample_controller. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ds, grant hook)
Superseded by SDK-side single-decision sampling. precompute.go/window.go drop
the SampleIdentitySetter interface and the per-observation identity-threading
hook. sketches/{cms,countsketch,ddsketch}.go drop SetSampleIdentity +
consistent* fields, reverting to each wrapper's native GeometricSampler-only
path. asapedgeprocessor/warm_sketch.go drops the OnGrant → otlpfilter.Upsert
wiring and the now-uncalled wireSampleRows helper.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
zzylol
force-pushed
the
pr-b3-integration
branch
from
July 16, 2026 03:50
26261fc to
e2dcdc7
Compare
Contributor
Author
|
Superseded by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3/3 of the old #510, stacked on the monitor PR.
Wires sampling (#508b-1) + the monitor grant (#508b-2) into the edge runtime:
asap-precompute-go/sketches/*+asap-precompute-rs/*),pinto the wrapper (SetSampleIdentity), so the wrapper's per-row admissions match the wire filter exactly,asap_edgeprocessor + OCB manifests, and theotel-appsample_controller.Needs sketchlib-go #69 (per-cell delta + ConsistentSampler).
🤖 Generated with Claude Code