mvp v6.1: fix typed-stage-split fire + backend image rebuild + freshness probe routing - #301
Merged
Merged
Conversation
Three integration gaps that the v6 demo (PR #300) surfaced as `not-exercised`/`v5-merge-pending`/empty CSVs. (1) Typed-stage-split path never fired. The block lives inside `handle_plan` (`controller/src/main.rs:465+`); the workload-registry pre-pop loop at startup uses a different code path. The driver now POSTs each canonical workload to /api/v1/plan after stack settle so the typed path is exercised end-to-end. (2) v6 overlay omitted backend env + per-metric routing. Without ASAP_GORILLA_S3_* and ASAP_BACKEND_STORAGE_ROUTING the cold-archive engine isn't registered and every query lands on the warm tier. Mirror the wiring already proven in baseline-b6-asap-single-sketch.yml, plus the asap-gorilla MinIO bucket seed. (3) YAML `<<:` merge does NOT deep-merge per-service environment maps under docker-compose, so the producer-* services were missing EXPORTER_FRESHNESS_PROBES + EXPORTER_RATE / FREQ_HZ from the anchor. Inline the full env per producer. CONTROLLER_BACKEND_ENDPOINT also wired so the typed-backend JSON push has a real target instead of silently logging "no client configured". See v6-1-diagnosis.md for full diagnosis. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The first v6.1 run captured §8 STATUS=`not-exercised` even though the controller's typed-stage-split path actually fired. Two small fixes: 1. The driver's STATUS detector greps `controller.stderr` only. Rust's `tracing_subscriber::fmt::init()` writes events to stdout, so docker logs splits them into our `controller.stdout` capture. Grep both files. 2. CONTROLLER_BACKEND_ENDPOINT must include the `/api/v1/streaming-config` path component — the BackendClient POSTs to the configured URL verbatim. Without the path, the typed backend JSON push hits the backend's root and gets a 404. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Captures the run-output artifacts referenced in the v6.1 PR comment.
Headline:
§8 STATUS: not-exercised → live
Crit ⑤: FAIL → PASS (gorilla_archive marker present)
Crit ⑥: UNKNOWN → UNKNOWN (deeper backend wiring required;
routing yaml + producer env are
fixed but SimpleEngine has no
pattern registered for
http_freshness_probe_*)
§4 / §6: v5-merge-pending / 0 (gorilla engine doesn't support
`count(...)`, so the postings
query returns 4xx; cost tracker
stays at 0 because no successful
archive query in the 60s window)
Two of three gaps closed. The third needs SimpleEngine pattern
registration for the freshness probe metric (or a streaming-config
overlay), which is a backend change beyond the scope of v6.1's
compose-overlay + driver fixes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v6 demo (PR #300) shipped honest measurements with three integration gaps. v6.1 diagnoses each and applies minimal fixes; full diagnosis lives in
v6-1-diagnosis.md.not-exercised). Root cause: the[USE_TYPED_STAGE_SPLIT]block lives inhandle_plan(controller/src/main.rs:465+), which is reached only onPOST /api/v1/plan. The startup workload-registry pre-pop loop callsplanner.plandirectly, bypassing the typed path. Fix: driver POSTs each canonical workload to/api/v1/planafter the OpAMP fabric settles. Also wiresCONTROLLER_BACKEND_ENDPOINT=http://backend:9091/api/v1/streaming-configso the typed-backend JSON push has a real target.asap/query-backend:dev(pre-SP-9: AST-aware hierarchical stage assignment (edge collector → leaf nodes, precompute engine → upper AST) #90 of ASAPQuery-backend); confirmed viagrep -ao postings_filtered|gorilla_archive|s3_coston the binary returning empty. Plus the v6 overlay didn't mountbackend-storage-routing.yamlor set theASAP_GORILLA_S3_*env block. v6.1 force-rebuilds with--no-cache(new sha729c390454d9) and adds the backend env wiring + routing yaml mount +asap-gorillaMinIO bucket seed (mirroringbaseline-b6-asap-single-sketch.yml).<<:doesn't deep-mergeenvironment:under docker-compose), missing routing config (gap 2), and SimpleEngine has no pattern registered forhttp_freshness_probe_*so warm-tier queries return "No matching pattern". v6.1 fixes the first two layers (env inlined per producer; routing now mounted). The third layer needs streaming-config additions in the backend, beyond the compose-overlay scope.v6 → v6.1 verdict diff
gorilla_archivemarker)count(...))Two of three gaps fully closed (§8 STATUS=live; criterion ⑤=PASS). Gap 3 partial — the routing wiring is correct now, but the backend's SimpleEngine doesn't auto-register patterns for new metrics, so freshness-probe queries return "No matching pattern". Honestly reported, not papered over.
Test plan
--no-cache(sha 729c390454d9 — v5 features in binary)nohup— wall ~7m total)live(controller logs show 3×[USE_TYPED_STAGE_SPLIT] pushing typed …events; STATUS detector now greps both stdout + stderr per Rust tracing default)data_source: gorilla_archive; verdict file = PASS)docker compose config