mvp v6 phase E: driver + report v6 (run pending v5 merge) - #300
Merged
Merged
Conversation
DRAFT — does not run the demo. Phase F brings up the stack and posts numbers once v5 PRs (#295 ASAPCollector, #90 ASAPQuery-backend) land. run_mvp_demo_v6.sh is independent from v5's run_mvp_demo.sh (which is in active use by the v5 demo run, PID 1945011) — separate file, separate output dir, separate report. Eight phases: 0. preflight (docker, docker-compose, compactor binary check) 1. stack up via base.yml + mvp-v6-multi-stage.yml + USE_TYPED_STAGE_SPLIT=1 2. measurements (replay + measure_stages.py + measure_per_edge_bandwidth.py) 3. freshness via run_freshness_phase.sh (raw/warm/archive) 4. ad-hoc postings exercise (count + topk-5xx) 5. cold-fallback verification (gorilla_archive marker) 6. compactor concat-only (dry-run + live) 7. teardown 8. mvp_report_v6.py reduce → MVP_REPORT_v6.md Captures controller-emitted runtime configs from /api/v1/collector-config/ and /api/v1/config/<metric>; falls back to placeholder gateway+agent configs when typed-stage-split returns None (logged as fallback-placeholder STATUS marker for the report). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Extends measure_stages.py's docker stats sampling with per-edge
labelling for the v6 fan-in topology:
edge_sdk_to_agent (10 producers TX)
edge_agent_to_gateway (2 agents TX)
edge_gateway_to_backend (backend RX — distinguishes the gateway's
split egress)
edge_gateway_to_s3 (minio RX — same rationale)
Output schema: edge,sample_ts_ms,window_s,bytes_total,bytes_per_s.
One row per (edge, sample) for a per-edge time-series; mvp_report_v6.py
reduces to per-edge mean B/s for criterion ① bandwidth.
Stdlib only; same `docker stats --no-stream` mechanism as
measure_stages.py so two probes can run in parallel without
docker-daemon contention.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Independent from v5's mvp_report.py (which is in active use, PID 1945011).
Eight sections:
§1 Stage-separated resource table (per-stage TOTAL across containers)
§2 Six-criterion verdict table (bandwidth/latency/resource/accuracy/
cold-fallback/freshness)
§3 Per-query-class breakdown (window/label/combined latency + accuracy)
§4 Postings filtering effect (gated on v5 merge — renders
v5-merge-pending markers if response fields absent)
§5 Compaction effect (before/after MinIO object count + bytes)
§6 S3-ops cost (gated on v5 cost tracker endpoint)
§7 Honest caveats (no replan, no hot reconfig, 10K not 1M, single host)
§8 Controller-emitted runtime configs status (live /
fallback-placeholder / not-exercised)
Pure stdlib, idempotent. Reads the v6 results dir layout written by
run_mvp_demo_v6.sh.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Hermetic — no compose stack, no docker. Synthesises a minimal v6
results directory layout (with mock CSVs / JSON / JSONL fixtures
clearly marked synthetic) and asserts:
* happy-path: all 8 sections present, all 6 criteria rows in §2,
all 5 stages in §1, all 3 query classes in §3
* idempotency: re-running over the same CSVs produces byte-identical MD
* sparse fixture (only stages.csv): renderer still produces complete
MD with UNKNOWN verdicts, v5-merge-pending markers in §4 / §6
* fallback emitter status renders correctly in §8
* missing --results-dir produces self-explanatory MD rather than crashing
* helper unit tests (per-edge mean, query-class classifier,
minio-listing counter, postings field extractor)
9 tests, all pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zzylol
marked this pull request as ready for review
May 6, 2026 21:53
This was referenced May 6, 2026
zzylol
added a commit
that referenced
this pull request
May 7, 2026
…ess probe routing (#301) * mvp v6.1: fix typed-stage-split fire + backend overlay + freshness env Three integration gaps that the v6 demo (PR #300) surfaced as `not-exercised`/`v5-merge-pending`/empty CSVs. (1) Typed-stage-split path never fired. The block lives inside `handle_plan` (`controller/src/main.rs:465+`); the workload-registry pre-pop loop at startup uses a different code path. The driver now POSTs each canonical workload to /api/v1/plan after stack settle so the typed path is exercised end-to-end. (2) v6 overlay omitted backend env + per-metric routing. Without ASAP_GORILLA_S3_* and ASAP_BACKEND_STORAGE_ROUTING the cold-archive engine isn't registered and every query lands on the warm tier. Mirror the wiring already proven in baseline-b6-asap-single-sketch.yml, plus the asap-gorilla MinIO bucket seed. (3) YAML `<<:` merge does NOT deep-merge per-service environment maps under docker-compose, so the producer-* services were missing EXPORTER_FRESHNESS_PROBES + EXPORTER_RATE / FREQ_HZ from the anchor. Inline the full env per producer. CONTROLLER_BACKEND_ENDPOINT also wired so the typed-backend JSON push has a real target instead of silently logging "no client configured". See v6-1-diagnosis.md for full diagnosis. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * mvp v6.1 follow-ups: STATUS detector grep stdout + backend endpoint path The first v6.1 run captured §8 STATUS=`not-exercised` even though the controller's typed-stage-split path actually fired. Two small fixes: 1. The driver's STATUS detector greps `controller.stderr` only. Rust's `tracing_subscriber::fmt::init()` writes events to stdout, so docker logs splits them into our `controller.stdout` capture. Grep both files. 2. CONTROLLER_BACKEND_ENDPOINT must include the `/api/v1/streaming-config` path component — the BackendClient POSTs to the configured URL verbatim. Without the path, the typed backend JSON push hits the backend's root and gets a 404. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * mvp v6.1: artifacts from the fix-and-rerun (v6 → v6.1) Captures the run-output artifacts referenced in the v6.1 PR comment. Headline: §8 STATUS: not-exercised → live Crit ⑤: FAIL → PASS (gorilla_archive marker present) Crit ⑥: UNKNOWN → UNKNOWN (deeper backend wiring required; routing yaml + producer env are fixed but SimpleEngine has no pattern registered for http_freshness_probe_*) §4 / §6: v5-merge-pending / 0 (gorilla engine doesn't support `count(...)`, so the postings query returns 4xx; cost tracker stays at 0 because no successful archive query in the 60s window) Two of three gaps closed. The third needs SimpleEngine pattern registration for the freshness probe metric (or a streaming-config overlay), which is a backend change beyond the scope of v6.1's compose-overlay + driver fixes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase E of the MVP v6 plan — author-mode. DRAFT — Phase F runs the demo against this driver once v5 PRs (#295 ASAPCollector + #90 ASAPQuery-backend) merge to main.
Three new scripts + one test module under `deploy/scripts/`:
Independent from v5's `run_mvp_demo.sh` + `mvp_report.py` — separate file, separate output dir, separate report. Those v5 files are NOT touched (in active use by v5 demo PID 1945011).
What Phase F needs to know
Test plan
Prior phases
Structural notes
🤖 Generated with Claude Code