Repository navigation
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Copy only the selected text when the selection consists entirely of footnote content, instead of substituting a numbered recovered definition. Keep full footnotes for selections that contain citing text and add a regression for partial citation footnote copying. Co-authored-by: Codex Web <noreply@openai.com>
Correct the footnote-label assertion so the test explicitly rejects a copied [12]: prefix rather than a backslash sequence. Co-authored-by: Codex Web <noreply@openai.com>
JFWooten4
added a commit
that referenced
this pull request
Oct 16, 2026
- 🔩 Copy clicked footnotes as Markdown when enabled Copy complete indexed footnote definitions when an inline footnote reference is clicked with Markdown copying enabled. Preserve navigation and existing highlight behavior, leave manual and scrubber navigation unchanged, and add clipboard/error regression tests. - 🔄 Sync brach to main Reconcile clicked-footnote Markdown copying with the selected changes already squashed into main. Preserve styled footnote selection from #187 and keep both #188 and #189 regression tests registered without discarding any prior changes. --------- Co-authored-by: Codex Web <noreply@openai.com>
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch changes two connected parts of the PDF reading/enhancement workflow:
[number]:definition directly after the paragraph containing its citation, and preserve bold/italic formatting from the note's PDF text spans. Automatically include an indexed footnote even when the copied selection contains its citation but not the full footnote text.lightanddeepenhancement modes pass--force-ocr --ai-reviewinstead of--skip-text, so even PDFs with an existing (possibly inaccurate) OCR layer are re-read and locally reviewed against page images.Details
Footnote selection and formatting
startsParagraphand apply it consistently when rendering text and reference markers.pageNumberto equal the reference's page, accommodating indexed regions extending across pages.This builds on the copied-footnote recovery introduced by #183 and its subsequent same-page/page-boundary correction in #184.
Enhancement pipeline
--force-ocr --ai-reviewfor both browser modes.PIPELINE_VERSIONfrom 3 to 4 so earlier completed enhancements are regenerated instead of reusing outputs made under the old pipeline.Regression coverage
The added tests are present in the branch, but I have not executed them locally in this workflow.
Review considerations
The OCR default is a deliberate cost and fidelity tradeoff: browser enhancement now re-rasterizes every page and runs local AI review, even when an embedded text layer is present. Reviewers should verify runtime/performance and any downstream implications for selectable text and accessibility.