targeting: add TargetingOncePerSession for wrappers that resolve targeting once - #353
Merged
Merged
Conversation
etiennelatendresse-optable
changed the title
etiennelatendresse-optable
force-pushed
the
targeting-session-guard
branch
3 times, most recently
from
September 28, 2026 19:05
ea27f48 to
50e0bbe
Compare
1 of 4 tasks
etiennelatendresse-optable
force-pushed
the
targeting-session-guard
branch
from
September 28, 2026 19:40
50e0bbe to
3342428
Compare
mosherBT
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
OPTABLE_TARGETING_DONEis the marker that says targeting already resolved this session. The SDK owns it. Its declared inlib/edge/targeting.tsand written bySkipTargetingForBots, but never exportedWhat Changed
TargetingOncePerSession(sdk, input?): skips the call when the marker is set, marks it on success, and resolvesnullinstead of rejecting when the call fails, so identity resolution cannot break the page. A failure leaves the marker unset, so a later page retries.SkipTargetingForBotswrites the marker through the same internal helper, so there is one writerHow to Test
Notes