Repository navigation
gpt: fix the contextual key-value test against always-emitted brand safety - #354
Merged
Merged
Conversation
mosherBT
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#352 makes
ContextualTargetingKeyValuesalways emit a brand-safety key, on purpose, so a line item can tell an assessed and clean page from an unassessed one. That means the map is never empty, and #337'squeues nothing when there are no key-valuesasserts something the code can no longer do.What Changed
gpt.test.js:queues nothing when there are no key-valuesopts out of both defaulted keys with{ keywordKey: "", brandSafetyKey: "" }, so it tests the empty-map guard ingpt.tsagain instead of a state that is now unreachable.gpt.test.js: newqueues the brand-safety key for an unassessed page, covering the always-emit behaviour at the GAM layer. Nothing asserted it there.How to Test
Notes