Repository navigation
Remove workarounds for seabirdscientific before 3.0.0 - #55
Merged
Merged
Conversation
The dependency is now seabirdscientific >= 3.0.0, which has the 911plus status-bit fix (webbpinner/seabirdscientific#24) and the contour-grid fix (webbpinner/seabirdscientific#21), so the workarounds for earlier versions can't run: - status.py: drop status_fields_reversed() and read the status fields in the fixed order. The probe scan moves to tests/test_status.py, which still checks the installed version decodes every nibble. - plots.py: drop the one-column contour grid fallback. 3.0.0 pads the salinity grid by 1.0 in 0.1 steps, so it always has 11+ columns. The three validation filesets' SVGs are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #54. Now that the dependency is
seabirdscientific >= 3.0.0, the workarounds for older versions can't run anymore.Changes
status.py: removestatus_fields_reversed()and the reversed field order (fork issue 24).reconstruct_nibble()reads the four status fields in 3.0.0's order.probe_scanmoves intotests/test_status.py, wheretest_recovers_raw_nibble_from_installed_seabirdscientificstill checks all 16 nibbles against the installed seabirdscientific, so a change in the bit order would fail CI. The test that faked the old mapping is removed.plots.py: remove the fallback for a one-column contour grid ("density grid too narrow to contour"; fork issue 21). 3.0.0 pads the salinity grid by ±1.0 in 0.1 steps, so the grid always has at least 11 columns. I checked single-sample and near-freshwater inputs, which gave 12-column grids. The existing guard for casts with no salinity aboveTS_MIN_SALINITYstays, since seabirdscientific raises an error when there are no samples.Verification
uv run pytest: 292 passed. That's 2 fewer than before because the reversed-mapping test was removed. The R2R filesets were present, so the parity tests ran.ruff checkandruff format --checkpass.runon SP2613, RR2605 and BH18-18: all 33 SVGs are byte-identical to the output before this change.🤖 Generated with Claude Code