Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1. The issue does not happen with
run_detectorsbecauserun_detectorsuseensure_assets_for_configmethod that does the correct comparison between the two paths. So if we just use the same solution it just works. I have added the_to_manifest_keywhere this path resolution happens so it's nice and clean.I would have also liked to throw an error and abort in line 108:
nicetoolbox/nicetoolbox/download_manager/manager.py
Lines 106 to 109 in 7026214
So when the download fails due to path error, the
download_assetsdoes not exit with code 0! But that is workflow dependent, and maybe for you this is the desired behavior. So I will leave that as is.