Skip to content

Revert @metamask/transaction-pay-controller changes not required - #9194

Merged
jpuri merged 3 commits into
mainfrom
revert_pay_ctrl_changes
Jun 18, 2026
Merged

jpuri merged 3 commits into
mainfrom
revert_pay_ctrl_changes

Conversation

@jpuri

@jpuri jpuri commented Jun 18, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

Revert @metamask/transaction-pay-controller changes not required

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

High Risk
Marked breaking in the PR; changes MM Pay relay user identity and whether post-quote same-token transfers fetch quotes, which can break account-override and same-token MM Pay flows that depended on #9150/#9187.

Overview
Reverts recent MM Pay relay and post-quote behavior in @metamask/transaction-pay-controller.

Relay quotes: Removes getQuoteUser and always sets the quote body user to the resolved from address. Same-chain, same-token flows with accountOverride no longer send txParams.from as user on non–post-quote requests.

Post-quote source amounts: calculatePostQuoteSourceAmounts no longer skips same-token-on-same-chain filtering when isQuoteRequired is true. Post-quote paths again drop identical source/destination tokens unless isHyperliquidSource or isPolymarketDepositWallet applies. isQuoteRequired still affects non–post-quote source amount logic elsewhere.

Changelog and tests for the reverted behavior are updated accordingly.

Reviewed by Cursor Bugbot for commit c4b3a2e. Bugbot is set up for automated code reviews on this repo. Configure here.

@jpuri
jpuri requested a review from a team as a code owner June 18, 2026 14:20
@jpuri
jpuri temporarily deployed to default-branch June 18, 2026 14:20 — with GitHub Actions Inactive
@jpuri
jpuri enabled auto-merge June 18, 2026 14:20
@jpuri
jpuri requested a review from a team as a code owner June 18, 2026 14:22
@jpuri
jpuri added this pull request to the merge queue Jun 18, 2026
Merged via the queue into main with commit b2f281e Jun 18, 2026
380 checks passed
@jpuri
jpuri deleted the revert_pay_ctrl_changes branch June 18, 2026 14:33
@cursor cursor Bot mentioned this pull request Jun 18, 2026
4 tasks done
@matthewwalsh0
matthewwalsh0 requested a review from vinistevam June 18, 2026 15:19
geositta added a commit that referenced this pull request Jun 18, 2026
* main: (497 commits)
  Release/1053.0.0 (#9195)
  Revert @metamask/transaction-pay-controller changes not required (#9194)
  chore: add discovery event names (#9178)
  chore: deprecate CurrencyRateController (#9182)
  Release/1052.0.0 (#9188)
  fix: getQuoteUser function is broken if request is not postQuote (#9187)
  fix(network-controller): Remove deprecated NetworkControllerGetNetworkConfigurationByNetworkClientId type (#9185)
  fix(network-controller): Remove MegaETH v1 default configuration (#9183)
  Release/1051.0.0 (#9181)
  fix: MM Pay transaction with isQuoteRequired that have same source and destination chain and token (#9150)
  Release/1050.0.0 (#9180)
  fix(network-controller): Only consider failover endpoints when using Infura (#9125)
  feat(assets-controllers): add isDeprecated to multichain controllers (#9044)
  refactor(smart-transactions-controller): import AuthenticationController namespace (#9167)
  Release 1049.0.0 (#9177)
  fix(transaction-pay-controller): vault musd via sentinel (#9161)
  Release 1048.0.0 (#9174)
  chore: remove orphaned semver.sh helper (#9172)
  fix(rpc-service): Consider all Infura HTTP errors as service failures except 400 and 429 (#9123)
  chore: remove outdated migrate-tags guide (#9171)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants