Revert @metamask/transaction-pay-controller changes not required - #9194
Merged
Merged
Conversation
vinistevam
approved these changes
Jun 18, 2026
geositta
added a commit
that referenced
this pull request
Jun 18, 2026
* main: (497 commits) Release/1053.0.0 (#9195) Revert @metamask/transaction-pay-controller changes not required (#9194) chore: add discovery event names (#9178) chore: deprecate CurrencyRateController (#9182) Release/1052.0.0 (#9188) fix: getQuoteUser function is broken if request is not postQuote (#9187) fix(network-controller): Remove deprecated NetworkControllerGetNetworkConfigurationByNetworkClientId type (#9185) fix(network-controller): Remove MegaETH v1 default configuration (#9183) Release/1051.0.0 (#9181) fix: MM Pay transaction with isQuoteRequired that have same source and destination chain and token (#9150) Release/1050.0.0 (#9180) fix(network-controller): Only consider failover endpoints when using Infura (#9125) feat(assets-controllers): add isDeprecated to multichain controllers (#9044) refactor(smart-transactions-controller): import AuthenticationController namespace (#9167) Release 1049.0.0 (#9177) fix(transaction-pay-controller): vault musd via sentinel (#9161) Release 1048.0.0 (#9174) chore: remove orphaned semver.sh helper (#9172) fix(rpc-service): Consider all Infura HTTP errors as service failures except 400 and 429 (#9123) chore: remove outdated migrate-tags guide (#9171) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Revert @metamask/transaction-pay-controller changes not required
References
Checklist
Note
High Risk
Marked breaking in the PR; changes MM Pay relay
useridentity and whether post-quote same-token transfers fetch quotes, which can break account-override and same-token MM Pay flows that depended on #9150/#9187.Overview
Reverts recent MM Pay relay and post-quote behavior in
@metamask/transaction-pay-controller.Relay quotes: Removes
getQuoteUserand always sets the quote bodyuserto the resolvedfromaddress. Same-chain, same-token flows withaccountOverrideno longer sendtxParams.fromasuseron non–post-quote requests.Post-quote source amounts:
calculatePostQuoteSourceAmountsno longer skips same-token-on-same-chain filtering whenisQuoteRequiredis true. Post-quote paths again drop identical source/destination tokens unlessisHyperliquidSourceorisPolymarketDepositWalletapplies.isQuoteRequiredstill affects non–post-quote source amount logic elsewhere.Changelog and tests for the reverted behavior are updated accordingly.
Reviewed by Cursor Bugbot for commit c4b3a2e. Bugbot is set up for automated code reviews on this repo. Configure here.