chore: add discovery event names - #9178
Merged
Merged
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
geositta
approved these changes
Jun 18, 2026
geositta
added a commit
that referenced
this pull request
Jun 18, 2026
* main: (497 commits) Release/1053.0.0 (#9195) Revert @metamask/transaction-pay-controller changes not required (#9194) chore: add discovery event names (#9178) chore: deprecate CurrencyRateController (#9182) Release/1052.0.0 (#9188) fix: getQuoteUser function is broken if request is not postQuote (#9187) fix(network-controller): Remove deprecated NetworkControllerGetNetworkConfigurationByNetworkClientId type (#9185) fix(network-controller): Remove MegaETH v1 default configuration (#9183) Release/1051.0.0 (#9181) fix: MM Pay transaction with isQuoteRequired that have same source and destination chain and token (#9150) Release/1050.0.0 (#9180) fix(network-controller): Only consider failover endpoints when using Infura (#9125) feat(assets-controllers): add isDeprecated to multichain controllers (#9044) refactor(smart-transactions-controller): import AuthenticationController namespace (#9167) Release 1049.0.0 (#9177) fix(transaction-pay-controller): vault musd via sentinel (#9161) Release 1048.0.0 (#9174) chore: remove orphaned semver.sh helper (#9172) fix(rpc-service): Consider all Infura HTTP errors as service failures except 400 and 429 (#9123) chore: remove outdated migrate-tags guide (#9171) ...
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add Perps Discovery analytics constants to
@metamask/perps-controllerWhat's added (constants only — no new events, no behavioral changes):
PERPS_EVENT_PROPERTYkeys:source_section, result_count,section_name,section_index,sections_displayed,watchlist_count,watchlist_marketsPERPS_EVENT_VALUE.SOURCE_SECTIONgroup (18 values across home, explore, and market-list origins)PERPS_EVENT_VALUE.SECTION_NAMEgroup (12 values for per-section impression tracking)INTERACTION_TYPEwithmarket_list_filterBUTTON_CLICKEDwithwatchlist,top_movers,whats_happeningBUTTON_LOCATIONwithasset_detailsTesting: 42 new unit tests in
tests/src/constants/eventNames.test.tsasserting exact string values for every new constant.Mobile follow-up (separate PR): After release + version bump, replace imports from the local mirror and delete the file.
References
Checklist