Repository navigation
Remove badges from README - #224
Merged
Merged
Conversation
Contributor
|
The codecov badge perhaps isn't useful to us, but it's flashy, and a positive signal. Why not keep it? |
Contributor
Author
|
I don't really think it's a particularly flashy/positive signal for others, I mean, we're not quite selling the usage of this project to anyone other than ourselves. 🤷♂ |
rekmarks
approved these changes
Apr 6, 2020
Member
|
We also broke |
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
* devDeps: @lavamoat/allow-scripts@^2.0.3->^2.3.1 * devDeps: typescript@4.2.4->4.8.4
Mrtenz
pushed a commit
to Mrtenz/core
that referenced
this pull request
Jun 17, 2026
Naz-Ovh
pushed a commit
to 0x-fork/metamask-core
that referenced
this pull request
Sep 13, 2026
Currently we use `assertStruct` in the `JsonStruct`, to ensure that the
value is JSON-serialisable before coercing it. `assertStruct` returns a
generic `AssertionError`, and Superstruct doesn't have any information
about where the error was thrown (such as the path). Given the following
struct for example:
```ts
const ExampleStruct = object({
value: JsonStruct,
});
```
An invalid `value` would result in an `AssertionError` with the
following message:
> Assertion failed: Expected a value of type `JSON`, but received:
`undefined`.
After this change, a `StructError` is thrown instead, with the following
message:
> At path: value -- Expected a value of type `JSON`, but received:
`undefined`.
This makes it more clear that the error happens at `value`, and it also
makes more sense to throw a `StructError` in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the badges from the README.
The build status badge isn't useful because 1) we don't use Travis CI anymore (#222) but also because the status is reflected elsewhere on the GH site. The 100% codecov badge isn't important since it is enforced.