Repository navigation
Conversation
Gudahtt
reviewed
Apr 6, 2020
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
Co-authored-by: Mark Stacey <markjstacey@gmail.com> --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: legobt <6wbvkn0j@anonaddy.me> Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Mrtenz
pushed a commit
to Mrtenz/core
that referenced
this pull request
Jun 17, 2026
Naz-Ovh
pushed a commit
to 0x-fork/metamask-core
that referenced
this pull request
Sep 13, 2026
<!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? Are there any issues or other links reviewers should consult to understand this pull request better? For instance: * Fixes #12345 * See: #67890 --> Our HD keyring [has been updated](MetaMask/accounts#100) to support different kinds of cryptographic functions to randomly generate a mnemonic, which may be an asynchronous operation in some cases. This PR updates the `generateRandomMnemonic` on the `Keyring` type accordingly, even though `eth-hd-keyring` does not implement the type yet, because `KeyringController` uses it as keyring interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #191
This PR migrates our CI from Travis CI to CircleCI. I've left out the
yarn doc& publishing config, since that doesn't work (#221) but we should re-add that later.One small note: I've added the
--maxWorkers=1flag to the unit test job to get it to work on CircleCI, I didn't debug the issue but was seeingENOMEMcoming from jest. 🤷♂