Skip to content

fix(desktop): engine starts in the home folder, not / (#186118) #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mayoalexander wants to merge 1 commit into
base: iris/1.18.23
Choose a base branch
from
Open

fix(desktop): engine starts in the home folder, not / (#186118) #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/desktop/src-tauri/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,13 @@ fn spawn_sidecar(app: &AppHandle, port: u32) -> CommandChild {
.resolve("", BaseDirectory::AppLocalData)
.expect("Failed to resolve app local data dir");

// The engine's working directory (#186118). An app opened from Finder / the Dock starts at `/`,
// and the sidecar inherited it — so a chat with no project folder ran its shell at the read-only
// root, and every relative write ("iris playbook install", exports, saves) targeted `/.iris`.
// Observed on a client's QA call: install failed until the agent `cd ~`'d. Home is where a person
// expects "here" to be when they have not opened a folder.
let engine_cwd = dirs_next_home().unwrap_or_else(|| std::path::PathBuf::from("/"));

#[cfg(target_os = "windows")]
let (mut rx, child) = app
.shell()
Expand All @@ -600,6 +607,7 @@ fn spawn_sidecar(app: &AppHandle, port: u32) -> CommandChild {
.env("OPENCODE_CLIENT", "desktop")
.env("XDG_STATE_HOME", &state_dir)
.env("IRIS_API_KEY", &iris_api_key)
.current_dir(&engine_cwd)
.args(["serve", &format!("--port={port}")])
.spawn()
.expect("Failed to spawn opencode");
Expand All @@ -613,6 +621,7 @@ fn spawn_sidecar(app: &AppHandle, port: u32) -> CommandChild {
.env("OPENCODE_CLIENT", "desktop")
.env("XDG_STATE_HOME", &state_dir)
.env("IRIS_API_KEY", &iris_api_key)
.current_dir(&engine_cwd)
.args(["serve", &format!("--port={port}")])
.spawn()
.expect("Failed to spawn opencode");
Expand Down
Loading