fix(desktop): engine starts in the home folder, not / (#186118) - #89
Open
mayoalexander wants to merge 1 commit into
Open
mayoalexander wants to merge 1 commit into
mayoalexander wants to merge 1 commit into
Conversation
…es stop targeting /.iris (#186118) An app opened from Finder or the Dock starts with cwd /, and spawn_sidecar did not set one, so the engine inherited it. A chat with no project folder ran its shell at the read-only root: every relative write (playbook install, exports, file saves) targeted /.iris. Found live on a client QA call — install failed until the agent ran cd ~. spawn_sidecar sets .current_dir(home) on both platform branches (dirs_next_home(), falling back to /). NOT compiled locally (no Rust toolchain on the authoring machine); the desktop release build compiles all platforms before anything is promoted. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0121oCnNCeZBewSyiQSQ8bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186118 — found live on a client QA call: in IRIS Desktop,
iris playbook installfrom the chat failed because the working directory was/; the agent had tocd ~.Cause. An app opened from Finder or the Dock starts with cwd
/, andspawn_sidecarnever set one, so the engine inherited it. A chat with no project folder ran its shell at the read-only root, and every relative write (installs, exports, saves) targeted/.iris.Fix.
spawn_sidecarsets.current_dir(home)on both platform branches (dirs_next_home(), falling back to/). 9 lines, one file.Verification — stated honestly. Not compiled locally: the authoring machine has no Rust toolchain and ~6 GB free, which is not enough for a Tauri build.
current_diris ontauri_plugin_shell::process::Commandin v2, anddirs_next_home()already exists in this file. The desktop release build compiles every platform before anything is promoted, so a mistake fails the build rather than shipping. Before release: open the app from the Dock with no project, ask the chat to runpwd→ expect the home folder.🤖 Generated with Claude Code
https://claude.ai/code/session_0121oCnNCeZBewSyiQSQ8bin