Skip to content

[No QA] Docs updates for E/A#99579 document All matching items selected label - #100628

Draft
MelvinBot wants to merge 1 commit into
mainfrom
docs-all-matching-items-selected-label
Draft

[No QA] Docs updates for E/A#99579 document All matching items selected label#100628
MelvinBot wants to merge 1 commit into
mainfrom
docs-all-matching-items-selected-label

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up to #99579, which restored the All matching items selected label on the selection button in Spend > Expenses.

The help site did not mention that label at all, and three step lists told members to select a button named Selected, which does not exist in the UI. The selection button always shows either a count (3 selected) or, after choosing Select all on Spend > Expenses, All matching items selected.

Changes:

  • docs/articles/new-expensify/reports-and-expenses/How-to-Export-Expenses.md
    • Replaced "Select Selected at the top" in all three bulk flows (export multiple expenses, download receipts, Export current view) with the real selection button labels.
    • Noted that the top checkbox opens a menu with Select all on this page and Select all when there is more than one page of expenses.
    • Added an FAQ entry explaining when the button reads All matching items selected and when it switches back to a count.
    • Added select all matching expenses and all matching items selected to keywords for retrieval.
  • docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md
    • Added the All matching items selected case and the select-all menu options to the grouped-expenses export flow, which runs on Spend > Expenses.
  • docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md
    • Added one sentence under How filtering works on the Spend page explaining that the button confirms the selection covers every expense matching the active filters.

Label strings were taken from src/languages/en.ts (search.exportAll.allMatchingItemsSelected, search.exportAll.selectAllOnThisPage, workspace.people.selectAll, workspace.common.selected) because the Melvin web test account has no expenses, so the bulk-selection UI does not render for a live capture. The navigation labels Spend and Expenses were confirmed in the live web UI.

Scope note: Spend > Reports wording was intentionally left alone, since the restored label only applies to expenses. The How-to-Export-Reports.md article still says "Select Selected at the top", which is a pre-existing inaccuracy outside the scope of this change.

Applied docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: exact UI labels in bold sentence case, no quotation marks around labels, unified web/mobile navigation phrasing, question-style FAQ heading, and no new # or ### headings.

npm run spell-changed passes on all three files.

Fixed Issues

$
PROPOSAL:

Documentation follow-up to #99579 (no separate issue).

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable. This PR only changes help site markdown under docs/articles.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@emkhalid, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Emkhalid <emkhalid@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 8, 2026 19:30
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 8, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#99579 document All matching items selected label [No QA] Docs updates for E/A#99579 document All matching items selected label Sep 8, 2026
@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@emkhalid

emkhalid commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot mark this PR as ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants