[No QA] Docs updates for E/A#100356 correct Report fields article to match current UI - #100515
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#100356 correct Report fields article to match current UI#100515MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
…tandards Co-authored-by: Abdelhafidh Belalia <s77rt@users.noreply.github.com>
40 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://c2c65327.helpdot.pages.dev ⚡️ Updated articles: |
Member
|
@stephanieelliott I can't change the PR description or make this ready for review. Can you please look into that or assign someone internal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Docs-only follow-up to #100356. While checking whether that PR needed help site updates, I compared
docs/articles/new-expensify/workspaces/Enable-Report-Fields.mdagainst the live product and found the article no longer matches the UI. That PR itself needs no docs change — this fixes the drift I found next to it.Accuracy fixes (each verified against the current UI on web):
The wrong navigation path was the most costly error — an admin following the old article looks under More features, finds nothing, and concludes the feature is missing from their workspace.
Compliance fixes against
docs/HELP_AUTHORING_GUIDELINES.md,docs/HELPSITE_NAMING_CONVENTIONS.md, anddocs/TEMPLATE.md:#headings into one#title plus# FAQ, as required — all content sections are now##.internalScopemetadata key, which was missing.[Learn more about connecting integrations.](#)link that pointed nowhere.<!-- SCREENSHOT: -->suggestion in the required format for the Reports tab location.The filename is unchanged, so the published URL still resolves. The
titlechanged from "Enable Report Fields" to "Create and Manage Report Fields" because the single permitted#heading now has to cover the create, edit, and delete sections too.UI evidence for the labels used in the article
The Report fields toggle on the Reports tab:
The four field types:
The List values page and its Add value button:
A saved field, showing that Name and Type have no chevron and Delete is inline:
AI Tests
./.github/scripts/createDocsRoutes.sh— passed,docs/routes.ymlalready up to date (routes key off the filename, which is unchanged).npm run spell-changed— passed, 0 issues.Lint, typecheck, Jest, and Storybook were not run: this change touches one Markdown article and no application code.
Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable — this PR changes one help site Markdown article and no application code.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@s77rt, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.