fix(sql-pg): Fail transactions that PostgreSQL rolls back at COMMIT

[fe-franco]

Problem

When a statement inside a transaction fails, PostgreSQL aborts the transaction. If the caller catches that error and the transaction body then succeeds, withTransaction sends COMMIT. PostgreSQL does not answer that COMMIT with an error. It rolls the transaction back and returns the command tag ROLLBACK.

makeWithTransaction runs the commit as Effect.orDie(options.commit(conn)) and never reads the result. So withTransaction reports success, and every write in the transaction is gone.

Reproduction

effect@4.0.0-rc.117 and @effect/sql-pg@4.0.0-rc.117, Postgres 17:

const exit = yield* sql.withTransaction(Effect.gen(function*() {
  yield* sql`INSERT INTO t VALUES (1)`
  yield* Effect.ignore(sql`SELECT 1 / 0`)
})).pipe(Effect.exit)
// exit is Success
// SELECT count(*) FROM t returns 0

The same body with the error inside a nested withTransaction commits correctly, because ROLLBACK TO SAVEPOINT repairs the transaction before COMMIT.

Fix

• SqlClient.make accepts an effect for commit as well as a string. This follows the onCommitFailure option added in Clean up SQLite transactions after failed commits #8529, and it is additive.
• @effect/sql-pg passes a commit that reads the command tag, which PgConnection.query already returns. On ROLLBACK it fails with a SqlError whose reason is UnknownError with operation: "commit". makeWithTransaction turns that failure into a defect, the same way it handles any failed COMMIT.

I chose UnknownError because no existing reason describes a rolled-back commit. I can add a dedicated reason instead if you prefer.

Validation

• pnpm lint-fix
• EFFECT_INTEGRATION_TESTS=1 pnpm test --run --project @effect/sql-pg: 16 files, 414 tests pass. The new test in Client.integration.test.ts fails before the fix.
• pnpm test --run packages/effect/test/sql: 54 tests pass.
• pnpm check

Closes EFF-1608

[changeset-bot]

🦋 Changeset detected

Latest commit: 2091937

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages

Name	Type
effect	Patch
@effect/sql-pg	Patch
@effect/opentelemetry	Patch
@effect/vitest	Patch
@effect/ai-anthropic	Patch
@effect/ai-openai-compat	Patch
@effect/ai-openai	Patch
@effect/ai-openrouter	Patch
@effect/ai-typesafe	Patch
@effect/atom-react	Patch
@effect/atom-solid	Patch
@effect/atom-vue	Patch
@effect/platform-browser	Patch
@effect/platform-bun	Patch
@effect/platform-deno	Patch
@effect/platform-node-shared	Patch
@effect/platform-node	Patch
@effect/sql-clickhouse	Patch
@effect/sql-d1	Patch
@effect/sql-libsql	Patch
@effect/sql-mssql	Patch
@effect/sql-mysql2	Patch
@effect/sql-pglite	Patch
@effect/sql-sqlite-bun	Patch
@effect/sql-sqlite-do	Patch
@effect/sql-sqlite-node	Patch
@effect/sql-sqlite-react-native	Patch
@effect/sql-sqlite-wasm	Patch
@effect/docgen	Patch
@effect/doctest	Patch
@effect/openapi-generator	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name	Current Size	Previous Size	Difference
arbitrary-combinators.ts	38.54 KB	38.54 KB	0.00 KB (0.00%)
basic.ts	6.88 KB	6.88 KB	0.00 KB (0.00%)
batching.ts	9.97 KB	9.97 KB	0.00 KB (0.00%)
brand.ts	6.57 KB	6.57 KB	0.00 KB (0.00%)
cache.ts	10.73 KB	10.73 KB	0.00 KB (0.00%)
config.ts	21.81 KB	21.81 KB	0.00 KB (0.00%)
differ.ts	20.95 KB	20.95 KB	0.00 KB (0.00%)
http-client.ts	22.11 KB	22.11 KB	0.00 KB (0.00%)
http-router.ts	33.33 KB	33.33 KB	0.00 KB (0.00%)
logger.ts	10.85 KB	10.85 KB	0.00 KB (0.00%)
metric.ts	8.83 KB	8.83 KB	0.00 KB (0.00%)
optic.ts	6.80 KB	6.80 KB	0.00 KB (0.00%)
pubsub.ts	15.00 KB	15.00 KB	0.00 KB (0.00%)
queue.ts	11.88 KB	11.88 KB	0.00 KB (0.00%)
schedule.ts	11.03 KB	11.03 KB	0.00 KB (0.00%)
schema-bigdecimal.ts	13.48 KB	13.48 KB	0.00 KB (0.00%)
schema-binary.ts	39.53 KB	39.53 KB	0.00 KB (0.00%)
schema-class.ts	20.65 KB	20.65 KB	0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts	31.72 KB	31.72 KB	0.00 KB (0.00%)
schema-representation-roundtrip.ts	26.92 KB	26.92 KB	0.00 KB (0.00%)
schema-string-transformation.ts	14.18 KB	14.18 KB	0.00 KB (0.00%)
schema-string.ts	11.73 KB	11.73 KB	0.00 KB (0.00%)
schema-template-literal.ts	15.75 KB	15.75 KB	0.00 KB (0.00%)
schema-toArbitrary.ts	38.08 KB	38.08 KB	0.00 KB (0.00%)
schema-toCodeDocument.ts	25.13 KB	25.13 KB	0.00 KB (0.00%)
schema-toCodecJson.ts	19.88 KB	19.88 KB	0.00 KB (0.00%)
schema-toEquivalence.ts	20.04 KB	20.04 KB	0.00 KB (0.00%)
schema-toFormatter.ts	20.14 KB	20.14 KB	0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts	24.64 KB	24.64 KB	0.00 KB (0.00%)
schema-toRepresentation.ts	20.14 KB	20.14 KB	0.00 KB (0.00%)
schema.ts	19.86 KB	19.86 KB	0.00 KB (0.00%)
stm.ts	12.90 KB	12.90 KB	0.00 KB (0.00%)
stream.ts	9.82 KB	9.82 KB	0.00 KB (0.00%)