Skip to content

Clean up SQLite transactions after failed commits - #8529

Merged
tim-smart merged 15 commits into
mainfrom
agent/bob/b4a0c5995201
Sep 25, 2026
Merged

tim-smart merged 15 commits into
mainfrom
agent/bob/b4a0c5995201

Conversation

@tim-smart

Copy link
Copy Markdown
Contributor

SQLite can leave a transaction open when a deferred foreign-key constraint rejects COMMIT. Run a driver-specific rollback before returning the connection to the single-connection client. If rollback fails or the transaction remains open, reject future acquisitions instead of reopening the database and losing in-memory data. Preserve the original COMMIT defect and include cleanup failure in its cause. Other drivers keep their existing COMMIT behavior.

Includes the previously committed SQLite regression test. Validation: SQLite Node client suite (13 passed), SqlClient suite (9 passed), TypeScript build, dprint, and git diff --check.

Closes EFF-1587
Closes #8521

@changeset-bot

changeset-bot Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7ddebdf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
effect Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-wasm Patch
@effect/sql-sqlite-react-native Patch
@effect/opentelemetry Patch
@effect/vitest Patch
@effect/ai-anthropic Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/ai-typesafe Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-deno Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-do Patch
@effect/docgen Patch
@effect/doctest Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
arbitrary-combinators.ts 38.53 KB 38.53 KB 0.00 KB (0.00%)
basic.ts 6.88 KB 6.88 KB 0.00 KB (0.00%)
batching.ts 9.97 KB 9.97 KB 0.00 KB (0.00%)
brand.ts 6.57 KB 6.57 KB 0.00 KB (0.00%)
cache.ts 10.73 KB 10.73 KB 0.00 KB (0.00%)
config.ts 21.82 KB 21.82 KB 0.00 KB (0.00%)
differ.ts 20.96 KB 20.96 KB 0.00 KB (0.00%)
http-client.ts 22.11 KB 22.11 KB 0.00 KB (0.00%)
http-router.ts 33.45 KB 33.45 KB 0.00 KB (0.00%)
logger.ts 10.85 KB 10.85 KB 0.00 KB (0.00%)
metric.ts 8.83 KB 8.83 KB 0.00 KB (0.00%)
optic.ts 6.80 KB 6.80 KB 0.00 KB (0.00%)
pubsub.ts 15.00 KB 15.00 KB 0.00 KB (0.00%)
queue.ts 11.87 KB 11.87 KB 0.00 KB (0.00%)
schedule.ts 11.03 KB 11.03 KB 0.00 KB (0.00%)
schema-bigdecimal.ts 13.42 KB 13.42 KB 0.00 KB (0.00%)
schema-binary.ts 39.56 KB 39.56 KB 0.00 KB (0.00%)
schema-class.ts 20.66 KB 20.66 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 31.69 KB 31.69 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 26.88 KB 26.88 KB 0.00 KB (0.00%)
schema-string-transformation.ts 14.14 KB 14.14 KB 0.00 KB (0.00%)
schema-string.ts 11.70 KB 11.70 KB 0.00 KB (0.00%)
schema-template-literal.ts 15.70 KB 15.70 KB 0.00 KB (0.00%)
schema-toArbitrary.ts 38.06 KB 38.06 KB 0.00 KB (0.00%)
schema-toCodeDocument.ts 25.12 KB 25.12 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 19.89 KB 19.89 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 20.06 KB 20.06 KB 0.00 KB (0.00%)
schema-toFormatter.ts 20.16 KB 20.16 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 24.64 KB 24.64 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 20.15 KB 20.15 KB 0.00 KB (0.00%)
schema.ts 19.87 KB 19.87 KB 0.00 KB (0.00%)
stm.ts 12.90 KB 12.90 KB 0.00 KB (0.00%)
stream.ts 9.82 KB 9.82 KB 0.00 KB (0.00%)

Comment thread .changeset/sqlite-failed-commit-recovery.md Outdated
@tim-smart
tim-smart enabled auto-merge (squash) September 25, 2026 10:45
@tim-smart
tim-smart merged commit 2a8f5c7 into main Sep 25, 2026
13 checks passed
@tim-smart
tim-smart deleted the agent/bob/b4a0c5995201 branch September 25, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rc.117 SqlClient.withTransaction leaves SQLite transaction open after deferred-constraint COMMIT failure

1 participant