Repository navigation
Conversation
kirtangajjar
approved these changes
Apr 23, 2021
kirtangajjar
left a comment
kirtangajjar
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you @hAbd0u for this!
Author
|
You are welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During some tests using PHP 7.4, I found a warring notice like this:
PHP Warning: Creating default object from empty value in /root/workspace/easyengine-74/vendor/easyengine/site-command/src/Site_Command.php on line 46This is happen when trying to access a property or method but it is null, or the object is not yet initialized. To fix this, I check if the object exist first.