Repository navigation
Conversation
kirtangajjar
approved these changes
Apr 23, 2021
kirtangajjar
left a comment
kirtangajjar
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you @hAbd0u for this!
Contributor
|
@mrrobot47 @dhsathiya We can test and ship this and EasyEngine/site-command#374 in our next release if everything goes well. |
Author
|
You are welcome, it is my duty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before merging this PR we need first another PR to get accepted and merged in their master repository, that package is required by
ee.Another PR I made must also get accepted before any merge.
The most thing we have to make attention for it in future is
implodefunction, before PHP 7.4 the arguments order was not important, but now it is.When the previous PR's get merged then we can merge this safely.