refactor(server): remove legacy administration surfaces - #34
Merged
Conversation
Remove unused server administration routes, role scaffolding, and proxy admin settings while preserving authentication and coding CLI commands. Cover removed routes, legacy claims, and retained network policy. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Contributor
Author
|
@greptileai please review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/v1/admin/*routes and their 697-line module, obsolete role/profile helpers, and unused network-proxy admin settings.Test plan
cargo fmt --all -- --check./scripts/clippy.shcargo test --locked --offline --workspace --no-fail-fast: 6,180 passed, 0 failed, 212 ignored across 139 suites, including doctests.cargo auditwith existing policy; the pre-existing GitHub Dependabot alert feat(harness): align CLI with keep-set, Task, and Code agent API #2 is not resolved by this cleanup.main: 12 router tests, 22 proxy tests, three CLI schema tests, formatting, policy and coverage pass.1de74fb16460b1a9b79513db18d9e02ae3431808: 1/1 executable line covered, no absent production source. Most changes are deletions or tests. The earlier 745/873 figure included readiness changes against an older base and is not this PR's denominator.72850424c11d8061d072edc260d23c53274393da, run 34100633310.Attestation (required)
.envfiles, diagnostic journals, aggregates, or build artifacts are included.Risk
Intentional API removal: the eight administration routes return 404 after authentication, while unauthenticated requests still receive 401 when authentication is enabled. Removed Rust administration types/fields/helpers are source-level API changes. Legacy JWT role/profile claims are ignored and cannot confer privileges. Old proxy admin fields deserialize as unknown fields and no longer serialize.
The server remains an authenticated operator workspace, not a mutually untrusted multi-tenant sandbox. Full coding-feature parity and non-Linux/live-service behavior are not established by this cleanup. No merge or release is requested.