feat(readiness): add quality gates and harden local runtime - #22
Merged
Conversation
Add source and dependency policies, reproducible setup, test reports, changed-line coverage, generated contracts, and real-process local QA. Connect server authentication and runtime controls, constrain workspace file operations, and add opt-in private diagnostics without exporters. Fix feature initialization, CLI flag conflicts, stale doctests, and append completion, with regression tests and documented limitations. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Install the components required by rust-toolchain.toml before dependency analysis instead of relying on rustup's implicit component installation. Keep the source and unused-dependency gates unchanged. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Install Git and ripgrep in test, coverage, and stability jobs so the real local readiness check can exercise its required tools. Report only the closed check results when the doctor integration test fails. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Create the report directory before llvm-cov exports LCOV and document the same prerequisite locally. Add workflow regression tests for the Rust components, doctor tools, and coverage directory ordering. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
echobt
marked this pull request as ready for review
September 6, 2026 22:22
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR publishes the complete remediation branch. The already-authorized GitHub settings changes require one main-branch approval and add priority/area labels. No merge or release is requested. All checks passed on the published head. Independent review is still required.
Test plan
cargo fmt --all -- --check./scripts/clippy.shcargo test --workspace, run ascargo test --locked --offline --workspace --no-fail-fast, including doctestscargo audit, with existing documented exceptions unchanged2e24cba2ed05d2833edaf06e9e1a34d0f65d6cc5ff0b9b4The development image built and passed an unprivileged, network-disabled prerequisite smoke test. Full editor-driven post-create setup and authenticated interactive TUI/coding-service QA were not verified.
Attestation (required)
I attest that:
.envfiles are included..env.exampledocuments names only.Risk
Substantive server auth/API and filesystem-boundary changes require careful review. The server is not a mutually untrusted multi-tenant sandbox, and these tests do not establish complete TOCTOU protection.
Diagnostics are opt-in, bounded, private, and local-only. CI uploads synthetic test/coverage/QA case reports, not diagnostic journals, aggregates, or server logs.
The quality gate retains 178 inherited findings rather than pretending to eliminate existing debt. Dynamic feature consumers still need human review; no new feature flags were introduced.
Release cadence, backlog health, non-Linux execution, live coding-service QA, full Dev Containers setup, CPU sampling, and a new persisted readiness score are not established by this PR.
GitHub still reports the pre-existing medium Dependabot alert #2 on
main(GHSA-w9wp-h8wv-79jx). This PR does not claim to resolve that alert.See
docs/guides/readiness-remediation.mdfor the verified pre-publication snapshot and explicit limitations.GitHub CI result
CI run 34063315988 passed on
ff0b9b461bbb3b3e9bf005fb6c347816e2e3a8a6. All 12 checks passed, including CodeQL and CI Success. Remote changed-line coverage is 750/879 (85.32%), with no absent production files.Earlier runs exposed missing clean-runner prerequisites. Those failures were fixed and covered by regression tests; no gates, thresholds, or tests were disabled. No merge or release was performed.