Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

Split out expressions to there down project - #3615

Closed
Rosuavio wants to merge 1 commit into
CommunityToolkit:masterfrom
Rosuavio:split-expressions
Closed

Rosuavio wants to merge 1 commit into
CommunityToolkit:masterfrom
Rosuavio:split-expressions

Conversation

@Rosuavio

@Rosuavio Rosuavio commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

Moves the "Expressions" code from the Animations package to its own package.

Helps push towards #3578 by making OrbitView and TileControl not depend on Animations.

PR Type

What kind of change does this PR introduce?

  • Feature
  • Refactoring (no functional changes, no api changes)

What is the current behavior?

The Expressions are in the animations package and namespace.

What is the new behavior?

Expressions are in there down package and namespace.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost

ghost commented Dec 9, 2020

Copy link
Copy Markdown

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost
ghost requested review from Kyaa-dost, azchohfi and michael-hawker December 9, 2020 18:40
@Rosuavio

Rosuavio commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

@michael-hawker I am assuming this causes some API breakage, is there anything we can/want to do about it?

@Rosuavio

Rosuavio commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

Also any feedback on where I am drawing the line on whats in this new package and what stays in the animations package would be helpful.

@michael-hawker

Copy link
Copy Markdown
Member

Thanks @RosarioPulella. I've been thinking about this too. Was going to chat a bit with @Sergio0694 on his thoughts on the line as well.

I'm wondering if we want more of a base 'Composition' specific package or not...

Let's hold-off on this for a bit and dive into this discussion. 🙂

@michael-hawker
michael-hawker marked this pull request as draft December 9, 2020 19:14
@michael-hawker

Copy link
Copy Markdown
Member

This has been superseded by #3639, closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants