Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

Remove Animations Package reference from Controls package #3578

Closed

Description

@michael-hawker

Describe the bug

The Animations package is currently being pulled in as a dependency for the Controls package. However, there's only two small uses of it in the package: RangeSelector for implicit animations, and ScrollHeader for the QuickReturnHeaderBehavior.

Expected behavior

I think removing the animation for the Tooltip in RangeSelector should be simple enough. I'm not as sure what we do with ScrollHeader as a component.

But migrating these off of the animation package or moving the ScrollHeader to a different package would be a big win for our dependency graph.

This may be dependent on work we do to clean-up the Behaviors/Animations package in general with its reliance on Win2D as well.

Tied to #3062 and #3145

Activity

  1. added this to the 7.0 milestone on Nov 24, 2020
  2. skendrot commented on Nov 24, 2020

    @skendrot
    Contributor

    I think using the composition api directly would be better than bringing in the animation package

  3. Rosuavio commented on Dec 4, 2020

    @Rosuavio
    Contributor

    I did some investigation on some of the interesting dependencies from the controls.

    ScrollHeader

    Microsoft.Xaml.Behaviors.Uwp.Managed

    Microsoft.Xaml.Interactivity;Microsoft.Xaml.Interactivity.Interaction.GetBehaviors(DependencyObject obj)

    Microsoft.Toolkit.Uwp.UI

    Microsoft.Toolkit.Uwp.UI.Extensions.VisualTree.FindAscendant<T>(this DependencyObject element)

    Microsoft.Toolkit.Uwp.UI.Animations

    Microsoft.Toolkit.Uwp.UI.Animations.Behaviors.FadeHeaderBehavior
    Microsoft.Toolkit.Uwp.UI.Animations.Behaviors.QuickReturnHeaderBehavior
    Microsoft.Toolkit.Uwp.UI.Animations.Behaviors.StickyHeaderBehavior

    TileControl

    Microsoft.Toolkit.Uwp.UI

    Microsoft.Toolkit.Uwp.UI.Extensions.VisualTree.FindDescendant<T>(this DependencyObject element)

    Microsoft.Toolkit.Uwp.UI.Animations

    Microsoft.Toolkit.Uwp.UI.Animations.Expressions.ExpressionNode
    Microsoft.Toolkit.Uwp.UI.Animations.Expressions.CompositionExtensions.GetReference(this Visual compObj)
    Microsoft.Toolkit.Uwp.UI.Animations.Expressions.CompositionExtensions.GetSpecializedReference<T>(this CompositionPropertySet ps)
    Microsoft.Toolkit.Uwp.UI.Animations.Expressions.ExpressionFunctions.Ceil(ScalarNode val)
    Microsoft.Toolkit.Uwp.UI.Animations.Expressions.ExpressionFunctions.Conditional(BooleanNode condition, ScalarNode trueCase, ScalarNode falseCase)
    Microsoft.Toolkit.Uwp.UI.Animations.Expressions.ExpressionFunctions.Abs(ScalarNode val)
    Microsoft.Toolkit.Uwp.UI.Animations.Expressions.ManipulationPropertySetReferenceNode

    Other

    ImageCropper, Eyedropper, InfiniteCanvas all use a bunch of win2d.

  4. Rosuavio commented on Dec 8, 2020

    @Rosuavio
    Contributor

    #3611 should take care of RangeSelector

  5. linked a pull request that will close this issueRemove animations from RangeSelector #3611on Dec 8, 2020
  6. linked a pull request that will close this issueRemove animations from RangeSelector #3611on Dec 8, 2020
  7. Rosuavio commented on Dec 9, 2020

    @Rosuavio
    Contributor

    #3615 Might be hamfisted but its something to remove TileControl's and OrbitViews dep on animation.

  8. ghost added a commit that references this issue on Dec 15, 2020
  9. ghost added a commit that references this issue on Dec 17, 2020
  10. michael-hawker commented on Jan 12, 2021

    @michael-hawker
    MemberAuthor

    This work has been completed.

  11. ghost locked as resolved and limited conversation to collaborators on Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions