Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

Fixed local errors in .NET Core 2.1 unit tests - #3365

Merged
1 commit merged into
CommunityToolkit:masterfrom
Sergio0694:bugfix/unit-test-error-core2_1
Jun 26, 2020
Merged

1 commit merged into
CommunityToolkit:masterfrom
Sergio0694:bugfix/unit-test-error-core2_1

Conversation

@Sergio0694

Copy link
Copy Markdown
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Build or CI related changes

What is the current behavior?

Some .NET Core 2.1 unit tests for the base package fail when run locally.

What is the new behavior?

All tests run correctly when executed locally.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost

ghost commented Jun 25, 2020

Copy link
Copy Markdown

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned michael-hawker Jun 25, 2020

@michael-hawker michael-hawker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@michael-hawker

Copy link
Copy Markdown
Member

@Kyaa-dost can you check this out and run the tests locally on your box as well?

@ghost

ghost commented Jun 25, 2020

Copy link
Copy Markdown

Hello @michael-hawker!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker michael-hawker added this to the 7.0 milestone Jun 25, 2020

@Kyaa-dost Kyaa-dost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to 🚀 🚀 Thanks @Sergio0694 !!

@Sergio0694

Copy link
Copy Markdown
Member Author

Happy to help, thank you for trying this out @Kyaa-dost! 😊

@ghost
ghost merged commit 76032fe into CommunityToolkit:master Jun 26, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants