You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 25, 2026. It is now read-only.
When Reset Button clicked, the TextBox did not update the UI. However, if we delete one digit at the back or delete any digit, the value updated.
Expected behavior
When ResetToDefault Button clicked:
OpeningTime should be showing: 00:00:00
ClosingTime should be showing: 23:59:59
Screenshots
As we can see here, if the value entered following the mask correctly, and then we update the value via binding, the TextBox did not properly reflect the changes. However, if one of the digit is missing, the value is updated perfectly.
@Kyaa-dost I found the code. It seems the correct TextBox.Text was overridden by the oldtext. The binding works normally but was overridden. Will try to fix this and create PR later.
@rizamarhaban sounds like you just cloned the main repo. If you create a fork in GitHub:
You should be able to change your remote to your new fork, then you can push your feature branch to your fork, and then submit a PR to our main repo here with the fix!
Let us know if you need more help submitting the PR! Thanks!
@michael-hawker I'm getting this failed test when running the unit tests. Is this something that I should leave it? it seems has no relation with my simple changes. Other tests passed.
Mmmh those crashes are very weird, also I'm pretty sure those FileNotFound are due to some referenced package not being loaded correctly. @michael-hawker have some NuGet packages been updated in the 7.0 branch? I see the CI is running all tests just fine in master 🤔
@rizamarhaban thanks, we've found the issue and it will be resolved by #3365. So, don't worry about those tests failing locally, you should be all good, thanks!
I also was able to repro similar issues with just XAML directly here in the sample app:
@michael-hawker Actually the second issue, the OutOfMemoryException from that HighPerformance test, has already been solved (that was in #3350), so if that has been merged into this PR I think it should already be fixed in here as well 👍
Activity
Kyaa-dost commentedon Jun 8, 2020
@rizamarhaban Thanks for highlighting the bug. Is this something you can work on, create a PR ?
rizamarhaban commentedon Jun 8, 2020
Okay, will check the code first.
rizamarhaban commentedon Jun 9, 2020
@Kyaa-dost I found the code. It seems the correct
TextBox.Textwas overridden by theoldtext. The binding works normally but was overridden. Will try to fix this and create PR later.rizamarhaban commentedon Jun 9, 2020
@Kyaa-dost I have fixed the code however I cannot push my branch or create the PR. Need help on this.
michael-hawker commentedon Jun 9, 2020
@rizamarhaban sounds like you just cloned the main repo. If you create a fork in GitHub:
You should be able to change your remote to your new fork, then you can push your feature branch to your fork, and then submit a PR to our main repo here with the fix!
Let us know if you need more help submitting the PR! Thanks!
rizamarhaban commentedon Jun 10, 2020
@michael-hawker I'm getting this failed test when running the unit tests. Is this something that I should leave it? it seems has no relation with my simple changes. Other tests passed.
michael-hawker commentedon Jun 10, 2020
@rizamarhaban looks like the tests passed in the CI, but adding @Sergio0694 here for help with understanding why they might fail locally.
Sergio0694 commentedon Jun 10, 2020
Mmmh those crashes are very weird, also I'm pretty sure those
FileNotFoundare due to some referenced package not being loaded correctly. @michael-hawker have some NuGet packages been updated in the7.0branch? I see the CI is running all tests just fine inmaster🤔rizamarhaban commentedon Jun 11, 2020
@Sergio0694 @michael-hawker maybe this detail will help to resolve this,
My laptop has 32GB memory,
michael-hawker commentedon Jun 25, 2020
@rizamarhaban thanks, we've found the issue and it will be resolved by #3365. So, don't worry about those tests failing locally, you should be all good, thanks!
I also was able to repro similar issues with just XAML directly here in the sample app:
Taking a look at your PR suggested fix now, thanks!
Sergio0694 commentedon Jun 25, 2020
@michael-hawker Actually the second issue, the
OutOfMemoryExceptionfrom thatHighPerformancetest, has already been solved (that was in #3350), so if that has been merged into this PR I think it should already be fixed in here as well 👍fixes for case adding data at the end of the textbox (#3338)