fix(api): remediate OpenAPI drift — BYOC infrastructure and saved queries (#1027)

[sdairs]

Fixes #1027

Remediates all 70 OpenAPI drift findings in clickhouse-cloud-api. The dry run against the live spec now reports Actionable drift: 0. This is library-only: no new CLI surface.

Changes

• Snapshot: refreshed clickhouse_cloud_openapi.json from the live spec. This clears the 18 stale-snapshot findings.
• Enums:
  • ActivityType gains 7 new values: the organization_approved_domain_* values, organization_update_public_preview and organization_update_saml_query_ownership_migration.
  • ByocConfigState gains infra-degraded, infra-terminating and infra-upgrading.
  • Both Kafka tombstone-mode enums gain soft_delete.
• ByocConfig: adds account_id. account_name is now spec-deprecated, so it moves behind deprecated-fields and into DEPRECATED_FIELDS.
• BYOC infrastructure (beta):
  • New methods: organization_byoc_infrastructure_get, _progress_get and _validate.
  • New models: ByocInfrastructureDetails, Progress, ProgressStage (recursive), Validation, ValidationCheck, ValidatePostRequest, and the ByocInfrastructureTags map alias.
  • ByocInfrastructurePostRequest gains 9 BYO-VPC, Azure and tag fields. availabilityZoneSuffixes, displayName and vpcCidrRange are now Option, matching the spec's required[] (breaking for Rust callers; see the crate README).
• Saved queries (beta):
  • New domain files src/client/saved_queries.rs and src/models/saved_queries.rs.
  • New methods saved_query_list, _create, _get, _update and _delete. saved_query_list takes cursor/limit.
  • New models PublicSavedQuery, PublicSavedQueryListItem and PublicSavedQueryRequest. None is used in both directions, so no *Response split was needed.
• BETA_OPERATIONS now lists all 8 new operations.
• CLI: compile fix only. build_byoc_create_request wraps the now-optional fields in Some, and a new test pins the exact request JSON, which is unchanged.
• Classifiers: both classify-*.py scripts map the new saved-query files (the Cloud classifier to the service suite), and their fixtures are updated.
• The crate README.md is updated; the root README is unchanged.

Tests

• models_test: for every new response type, a missing key and an explicit null both give None. Also covers request strictness, a 3-level recursive progress stage, dynamic tag keys and the new enum round-trips.
• client_test (wiremock): all 8 new methods, checked for verb, path, cursor encoding, body, parsed response and error paths.
• Live integration: a new blocking Saved Queries phase in cloud_service_crud_lifecycle. It runs create ×2, a duplicate-name 409, paginated list, get, update and delete, then checks for 404s. Cleanup goes through CleanupRegistry.
  • Run live against the test org (aws/eu-west-1): passed in 363s, and the service was deleted afterwards.
  • That run used the endpoint phase's names. A final commit switches to a distinct -sq prefix, so the renamed version has not been run live.
• BYOC: no live coverage (there was none before either). Get and progress need real BYOC infrastructure, and validate needs a BYOC-enabled org.

Gates

cargo fmt, both clippy configurations and library --all-targets are clean. cargo check --workspace --all-features passes. The library and analyzer tests pass, including spec_coverage_test and the analyzer entrypoint_test, and so do the Python classifier tests. cargo test -p clickhousectl passes apart from the local_postgres_* tests, which need Docker and it wasn't running locally.

🤖 Generated with Claude Code