Repository navigation
Notebook rework 2: seven steps (Images, Axes, Channels, Masks, Design, Check and save, Run) - #276
Merged
Merged
Conversation
… axes; Channels; Masks; Design) Owner's test of the first redesign (10 November 2026), items (o), (p), (q). The stepper is Images, Axes, Channels, Masks, Design, Check and save, Run: - Axes asks the image type in one line for all folders, pre-filled from the image headers and recorded only by 'Use for all folders'; 'Set per folder' holds each folder's row; headers that differ pre-fill nothing and open it; replacing answers asks first. - Channels is the stains and the tags on one page. - Masks holds the paired masks, what each type is and the mask step, which waits visibly for a run that recorded masks (A_MASK_UNCHECKED unchanged). - Design is one grid (conditions x biological repeats, cells = folders, compared against as the last column) of proposals, adopted by one click 'Looks right: confirm the design' (the all-or-none ID adoption, and 'no comparison' where nothing else was chosen); Check and save waits for it and says so. - Check and save folds a long list of missing answers; every line is still there. For the same answers the published description, design, histograms, calibration, mask files and manifest (minus time and paths) are byte-identical to main; the stacked pages and the public methods other bricks embed are unchanged. Notebook Markdown and user guide section 4 describe the seven steps. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
The user guide's section 4 keeps the short seven-step text: the card-by-card text main edited (the unread legacy experiment_design.csv) is no longer there. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Contributor
Author
|
Checks on the head 85aeaaf (main f71e62f merged in through #275; the only conflict was the user guide's §4, where main had edited card-by-card text this PR removes):
Generated by Claude Code |
One conflict in notebook_compact._run_page: both the Masks hint (this branch) and the log text (rework-1-layout) are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Contributor
Author
|
Independent review, merged. The base is now main e858fa2 (#275 merged). Both of main's parents are ancestors of this head, so the merged tree is the tree that was gated.
Notes for the owner, not blockers:
🤖 Generated with Claude Code https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc Generated by Claude Code |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #275. Owner's test of the first redesign (10 November 2026), items (o), (p) and (q): 12 steps become 7, in the owner's order, what the files hold first and what it means after.
The flow
R_HETEROGENEOUS_LAYOUT_NOT_ENABLED); colour pictures beside separate-channel images are still refused at the axes, as on main.Does Describe the masks need the run? Yes
Verified in the code: the mask step reads the inputs the run recorded (
mask_step.recorded_masks(output),prepare_mask_step(None, output_folder)), so it cannot run before a run exists. It is therefore an action of the Masks step that is greyed out, with its reason in a visible line, until a run recorded masks; after such a run the run step says to come back for it. Nothing aboutA_MASK_UNCHECKEDchanges (a brick still refuses a mask this step has not read). Moving the mask check before the run would need a change of the mask step itself: not done here, listed as a question.Safety rules
tests/test_spec_*.pyare untouched and pass.morphobricks.toml,experiment_design.csv,plane_histograms.csv,calibration.csv,mask_relationships.jsonandmask_representation.jsonare byte-identical;run_manifest.jsondiffers only inwritten_atand the output path (anddiscovery_report.*only in that manifest's hash). A test also pins that the stepper and the stacked pages publish the same description and design for the same answers.Embedding API
welcome,folder_step(all keyword arguments),axis_step,channels_step,masks_step,check_save_step,run_step,results_step,check_button,confirm_button,confirmed_mapping,preflightare unchanged;tests/test_embedding_api.pyis not modified and passes (the design's click is a private method so the pinned set of public methods stays exact). The stacked pages keep their cards, their own image-type column in the tag grid and the choose option of the comparison dropdowns.What an embedder can notice, all of it text on the stacked pages:
MorphoRelate (
folder_step(show_design=False),axis_step,run_step) and the MorphoFeature end-to-end notebook (welcome/steps/results_step) need no change. A brick that callssteps()gets the 7 steps.Tests adapted, with the reason
test_notebook_stepper.py,test_notebook_compact.py,test_notebook_stains_na.py,test_notebook_axes_quick.py: step titles and positions (12 → 7).test_notebook_check_save.answer_all: in the stepper it gives the Design step's one click (the save now waits for it).test_notebook_owner_fixes.py: "no comparison" is a proposal saved by the Design click, not by re-selecting what is already shown; a refused loop goes back to that proposal.test_notebook_masks.py,test_notebook_mask_step.py,test_notebook_tag_blocks.py: the texts listed above.test_notebook_seven_steps.py(20 tests).Docs
The notebook's Markdown cell (not its code cells, not
RELEASE_REF) anddocs/user_guide.md§4 describe the seven steps in short; the stale card-by-card text of §4 is removed.Checks
python tools/check.pyand CI: see the comment below.Not decided here (questions for the owner)
docs/colab-release-check.mdstill walks the earlier steps; to rewrite with the v0.5.1 release PR.Generated by Claude Code