Repository navigation
Notebook rework 1: one column, no inner scroll box, every channel in the quick scan; Compare groups in the run step - #275
Merged
Conversation
…tep; the app in short in the guide Owner test of v0.5.0 (10 November 2026), items (a) and (b). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
…n's picture keeps its size Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
…compact Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
…laude/redesign-4-compact Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
…hows every channel Owner's test of the first redesign (10 November 2026): - the step body no longer scrolls on its own, nor do tables and file lists in the stepper: the page scrolls as a whole; - always one column: the scan's pictures above its folders, the two buttons of step 1 one under the other, the axes step as roles, example, pixel size (one row per dimension); - the quick scan draws every channel of its one image side by side (own contrast, c= labels) when that image's header names a channel axis, up to 6, and says '6 of N channels shown' beyond; display only, read from that one image. Layout only: no answer, check, refusal or output changes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
This was referenced Nov 10, 2026
Merged
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Contributor
Author
|
Main (f71e62f, #274) is merged in; the head is 5793366.
Generated by Claude Code |
The single-column walk looked only at HBox rows holding a card directly, so cards side by side in a GridBox (main's axes step) or wrapped in a VBox were not found. The new test fails with the earlier helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
… that scrolls The stepper's run step held the log in a 14em read-only Textarea, a box with its own scroll bar (owner's test of the redesign: the page scrolls, nothing inside it). In the stepper the fold now shows the same log as wrapped text; the stacked run_step() is unchanged. Regression test fails before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Contributor
Author
|
Independent review of #275 and #276, then merge. Fixes on this branch, one commit each, each with a regression test that fails without the fix:
Checks:
🤖 Generated with Claude Code https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #273 (kept: the compact style, About this step, the Folders card, the collapsed Compare groups panel in the run step, the one-line
welcome(); removed: what the owner's test of that redesign rejected). Stacked: the 7-step flow is the next PR, on top of this one.Owner's test of the first redesign (10 November 2026): "scrolling in its own box is annoying and not better"; always a single column; the quick-scan image shows all channels.
What changes
.mb-compact .mb-table-wrap,.mb-paths, the per-folder picture rows). A step is short only because it says less, folds details and draws smaller pictures.c=label, when that image's header names a channel axis (header_preview.header_channels): up to 6; with 7 or more, 6 and the line "6 of N channels shown". Display only, read from that one image (bound to its fingerprint, within the caps of the header pictures). A header that names no channel axis gets the one picture as before: no channel is guessed from a shape.results_step()aftersteps()returns an empty hidden box).Layout only: no answer, check, refusal, draft, description or run output changes.
tests/test_embedding_api.pyis untouched and passes. The stacked pages other bricks embed (folder_step,axis_step) get the one-column axes layout (roles, example, named-axis copies card, then confirm); nothing else changes for them.Checks
python tools/check.pyon 109588f: 5254 passed, 4 skipped (the 4 environment skips: case-insensitive file system ×3, permissions that ignore file modes), Ruff and the code rules clean.rework-shots/before,rework-shots/after), at 1366×768 and 1920×1080.Generated by Claude Code