Skip to content

Create link_checker.yml - #465

Merged
ahouseholder merged 2 commits into
mainfrom
add-linkchecker-workflow
Feb 15, 2024
Merged

ahouseholder merged 2 commits into
mainfrom
add-linkchecker-workflow

Conversation

@ahouseholder

Copy link
Copy Markdown
Contributor

Adds a github workflow that builds the site and checks links anytime a PR wants to change a markdown file.

I feel obligated to acknowledge the entirely unintentional fact that issue #404 is the absolute best issue number possible for that specific issue.

This PR is a direct follow-on to

and should be merged immediately after #443 is merged. Rationale: #443 puts the content in a known-good state with no broken links that linkchecker can find. So if we add this workflow immediately afterwards, we can ensure that we keep it that way going forward. Merging this PR before #443 would just leave us with a failing workflow because there are a lot of broken links in the markdown up to that point.

Adds a github workflow that builds the site and checks links anytime a PR wants to change a markdown file.
@ahouseholder
ahouseholder requested a review from j--- February 14, 2024 17:34
@ahouseholder ahouseholder self-assigned this Feb 14, 2024
@ahouseholder ahouseholder added enhancement New feature or request tech/environment Project environment, deployment, CI, etc. labels Feb 14, 2024
@ahouseholder ahouseholder added this to the SSVC 202403 milestone Feb 14, 2024
@ahouseholder ahouseholder mentioned this pull request Feb 14, 2024

@j--- j--- left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so glad this will solve issue 404.

@ahouseholder
ahouseholder merged commit 529b779 into main Feb 15, 2024
@ahouseholder
ahouseholder deleted the add-linkchecker-workflow branch February 15, 2024 17:21
@ahouseholder ahouseholder modified the milestones: 2024.3, 1Q24 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request tech/environment Project environment, deployment, CI, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add link checker workflow as PR acceptance test

2 participants