Repository navigation
Fix broken links - #443
Merged
Merged
Fix broken links#443
Conversation
# Conflicts: # docs/reference/decision_points/public_safety_impact.md
# Conflicts: # docs/about/changelog.md
# Conflicts: # docs/howto/communicating_results.md # docs/topics/credibility_indicators.md # docs/topics/index.md # mkdocs.yml
ahouseholder
marked this pull request as ready for review
February 14, 2024 17:18
ahouseholder
requested review from
cgyarbrough,
j--- and
sei-vsarvepalli
as code owners
February 14, 2024 17:18
Merged
ahouseholder
commented
Feb 14, 2024
ahouseholder
left a comment
Contributor
Author
There was a problem hiding this comment.
As I was fixing links, I also took advantage of some opportunities to eliminate the need for some file includes by just merging the included content into the parent file. Hence there are a few file changes that look like they're adding content to files (which technically they are), but those are offset by removing the files that originally included that content.
j---
approved these changes
Feb 15, 2024
j---
left a comment
Collaborator
There was a problem hiding this comment.
thanks so much for fixing all of these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix as many broken links as possible following the conversion from our PDF-oriented workflow to our mkdocs-oriented workflow.
Converting from one massive file to a website left us with a lot of section links (links to heading anchors like
[Utility](#utility)that need to be replaced with links to files[Utility](../reference/decision_points/utility.md).By a quick search of the markdown content, I think there were over 500 such links to start. I believe I've fixed them all here.
Output from the python
linkcheckertool:Once merged, this PR puts us into a "known-good" ground state for link checking as well. I submitted a separate PR #465 as a downstream dependency on this one that will add a
linkcheckeracceptance test workflow for all future PRs.Note Once approved, this PR should be squash merged rather than a normal merge due to the fact that the individual commits have almost no meaning as they're all intermediate work-in-progress fixes.