Repository navigation
Add Decision Point Group Versioning ADRs - #368
Merged
ahouseholder merged 5 commits intoNov 7, 2023
Merged
Conversation
ahouseholder
requested review from
cgyarbrough,
j--- and
sei-vsarvepalli
as code owners
October 31, 2023 20:35
Contributor
Author
|
PR #369 would add ADR 0006 to supersede ADR 0003. I made #369 a PR against this one since it's technically a separate decision for us, but the ADR numbering depends on the assumption that this PR #328 is merged as well (with ADR 0004 and ADR 0005). If for some reason those assumptions go unmet, then PR #369 should renumber its new ADR accordingly. |
j---
approved these changes
Nov 7, 2023
…06) (#369) * revise ADR 0003 into ADR 0006 * fix header
ahouseholder
deleted the
355-create-adrs-for-decision-point-group-versioning
branch
November 7, 2023 17:34
This was referenced Nov 7, 2023
ahouseholder
added
content/semantic
This was referenced Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two ADRs:
As with #350, I separated these out so that the decision that they are versioned is distinct from the versioning rules.
It is my intent that existing decision point groups already present in the python code should be consistent with these rules. However, the rules were developed during the process of creating the python code, and written down afterwards. So any discrepancy is basically the result of an out-of-order operation. We should correct any such discrepancies we detect, of course, whether by modifying the code to match the rules, or perhaps adjusting the rules if there's a good reason to do so.