Skip to content

{CI} Fix lint issues introduced by Pylint 4.1.1 #34158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ethan Yang (necusjz) merged 2 commits into from
Oct 5, 2026
Merged

{CI} Fix lint issues introduced by Pylint 4.1.1 #34158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86c6fc4
fix: lint
necusjz Oct 2, 2026
1f13932
fix: lint
necusjz Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/azure-cli-core/azure/cli/core/commands/arm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------

# pylint: disable=line-too-long
Comment thread
necusjz marked this conversation as resolved.
# pylint: disable=too-many-lines

import argparse
Expand Down Expand Up @@ -75,7 +75,7 @@ def add_output(self, key, property_name, provider=None, property_type=None,
output_type='string', path=None):

if provider and property_type:
value = "[reference(resourceId('{provider}/{type}', '{property}'),providers('{provider}', '{type}').apiVersions[0])".format( # pylint: disable=line-too-long
value = "[reference(resourceId('{provider}/{type}', '{property}'),providers('{provider}', '{type}').apiVersions[0])".format(
provider=provider, type=property_type, property=property_name)
else:
value = "[reference('{}')".format(property_name)
Expand Down Expand Up @@ -175,8 +175,7 @@ def __new__(cls, val):
return str.__new__(cls, val)


def resource_exists(cli_ctx, subscription, resource_group, name, namespace, type,
**_): # pylint: disable=redefined-builtin
def resource_exists(cli_ctx, subscription, resource_group, name, namespace, type, **_): # pylint: disable=redefined-builtin
''' Checks if the given resource exists. '''
odata_filter = "resourceGroup eq '{}' and name eq '{}'" \
" and resourceType eq '{}/{}'".format(resource_group, name, namespace, type)
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/acs/azurecontainerstorage/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------
# pylint: disable=too-many-boolean-expressions
Comment thread
necusjz marked this conversation as resolved.

import re

Expand Down Expand Up @@ -357,7 +358,6 @@ def validate_enable_azure_container_storage_v1_params( # pylint: disable=too-ma
f'value set to {existing_ephemeral_disk_nvme_perf_tier}.'
)

# pylint: disable=too-many-boolean-expressions
if required_type_installed_for_disk_vol_type and \
ephemeral_disk_volume_type is not None and \
existing_ephemeral_disk_volume_type.lower() == ephemeral_disk_volume_type.lower() and \
Expand Down
12 changes: 6 additions & 6 deletions src/azure-cli/azure/cli/command_modules/acs/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,8 +1083,8 @@ def aks_create(
existing_mc = None
try:
existing_mc = client.get(resource_group_name, name)
# pylint: disable=broad-except
except Exception as ex:

except Exception as ex: # pylint: disable=broad-exception-caught
logger.debug("failed to get cluster, error: %s", ex)
if existing_mc:
raise ClientRequestError(
Expand Down Expand Up @@ -2942,8 +2942,8 @@ def append_install_dir_to_windows_user_path(install_dir, binary_name):
user_path = ""
try:
user_path = get_windows_user_path()
# pylint: disable=broad-except
except Exception as e:

except Exception as e: # pylint: disable=broad-exception-caught
logger.debug("failed to get user path, error: %s", e)
log_windows_post_installation_manual_steps_warning(
install_dir, binary_name)
Expand All @@ -2960,8 +2960,8 @@ def append_install_dir_to_windows_user_path(install_dir, binary_name):
try:
subprocess.run(setxexp, shell=True, check=True, capture_output=True)
log_windows_successful_installation_warning(install_dir)
# pylint: disable=broad-except
except Exception as e:

except Exception as e: # pylint: disable=broad-exception-caught
logger.debug("failed to set user path, error: %s", e)
log_windows_post_installation_manual_steps_warning(
install_dir, binary_name)
Expand Down
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/sql/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------

# pylint: disable=unused-argument
Comment thread
necusjz marked this conversation as resolved.
# pylint: disable=C0302
from enum import Enum
import calendar
Expand Down Expand Up @@ -1787,7 +1787,7 @@ def db_delete_replica_link(
# provided. We don't care about this parameter and it gets handled weirdly if we
# expliclty specify it with default value here (e.g. `yes=None` or `yes=True`), receiving
# it in kwargs seems to work.
**kwargs): # pylint: disable=unused-argument
**kwargs):
'''
Deletes a replication link.
'''
Expand Down
Loading