Skip to content

{CI} Fix lint issues introduced by Pylint 4.1.1 - #34158

Open
Ethan Yang (necusjz) wants to merge 2 commits into
Azure:devfrom
necusjz:fix-pylint-4.1.1
Open

Ethan Yang (necusjz) wants to merge 2 commits into
Azure:devfrom
necusjz:fix-pylint-4.1.1

Conversation

@necusjz

Copy link
Copy Markdown
Member

Related command

Description

Running pylint on modules...
Pylint: PASSED
ERROR: ************* Module azure.cli.command_modules.sql.custom
src/azure-cli/azure/cli/command_modules/sql/custom.py:1779:0: W0613: Unused argument 'kwargs' (unused-argument)
************* Module azure.cli.command_modules.acs.custom
src/azure-cli/azure/cli/command_modules/acs/custom.py:1087:11: W0718: Catching too general exception Exception (broad-exception-caught)
src/azure-cli/azure/cli/command_modules/acs/custom.py:2946:11: W0718: Catching too general exception Exception (broad-exception-caught)
src/azure-cli/azure/cli/command_modules/acs/custom.py:2964:11: W0718: Catching too general exception Exception (broad-exception-caught)
************* Module azure.cli.command_modules.acs.azurecontainerstorage._validators
src/azure-cli/azure/cli/command_modules/acs/azurecontainerstorage/_validators.py:361:19: R0916: Too many boolean expressions in if statement (6/5) (too-many-boolean-expressions)
************* Module azure.cli.core.commands.arm
src/azure-cli-core/azure/cli/core/commands/arm.py:178:76: W0622: Redefining built-in 'type' (redefined-builtin)

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

@necusjz
Ethan Yang (necusjz) marked this pull request as ready for review October 2, 2026 06:02
Copilot AI balanced review requested due to automatic review settings October 2, 2026 06:02
@yonzhan

Copy link
Copy Markdown
Collaborator

CI

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Three file-wide suppressions unnecessarily weaken lint coverage and should remain localized.

Review effort: Balanced
Findings: 3 Low severity

Open (3)
What changed in this PR

Updates Pylint suppressions for compatibility with Pylint 4.1.1.

Changes:

  • Updates renamed Pylint warning suppressions.
  • Relocates suppressions that no longer apply correctly.
  • Reformats the ARM helper signature.
File Description
sql/​custom.py Relocates unused-argument suppression.
acs/​custom.py Updates broad-exception suppression names.
acs/​azurecontainerstorage/​_validators.py Relocates boolean-complexity suppression.
core/​commands/​arm.py Adjusts line-length and built-in-name suppressions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/azure-cli-core/azure/cli/core/commands/arm.py
Comment thread src/azure-cli/azure/cli/command_modules/sql/custom.py

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants