Skip to content

#109 Improve testability and cleanup - #135

Merged
Av3boy merged 5 commits into
devfrom
109-av-tests
Jun 28, 2026
Merged

Av3boy merged 5 commits into
devfrom
109-av-tests

Merge remote-tracking branch 'origin/dev' into 109-av-tests

a905194
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 28, 2026 in 12s

Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 45 in SharpEngine.Core/Renderers/ParticleRenderer.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGICih1Y3gYnR6kU5&open=AZ8PGICih1Y3gYnR6kU5&pullRequest=135

Check failure on line 35 in SharpEngine.Core/Handlers/WindowHandler.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Dispose '_cancellationTokenSource' when it is no longer needed.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGIC-h1Y3gYnR6kU7&open=AZ8PGIC-h1Y3gYnR6kU7&pullRequest=135

Check failure on line 127 in SharpEngine.Core/Windowing/Window.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This method signature overlaps the one defined on line 116, the default parameter value can only be used with named arguments.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGIB7h1Y3gYnR6kU1&open=AZ8PGIB7h1Y3gYnR6kU1&pullRequest=135

Check failure on line 66 in SharpEngine.Core/Audio/AudioSource.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either implement 'IDisposable.Dispose', or totally rename this method to prevent confusion.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGIBmh1Y3gYnR6kU0&open=AZ8PGIBmh1Y3gYnR6kU0&pullRequest=135

Check warning on line 225 in SharpEngine.Core/Handlers/WindowHandler.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to 'MouseButton'.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGIC-h1Y3gYnR6kU9&open=AZ8PGIC-h1Y3gYnR6kU9&pullRequest=135

Check warning on line 42 in Examples/MultipleWindows/Program.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGH9Bh1Y3gYnR6kUt&open=AZ8PGH9Bh1Y3gYnR6kUt&pullRequest=135

Check warning on line 122 in Examples/MultipleWindows/Program.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to 'MouseButton'.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGH9Bh1Y3gYnR6kUy&open=AZ8PGH9Bh1Y3gYnR6kUy&pullRequest=135

Check warning on line 36 in SharpEngine.Core/Renderers/ParticleRenderer.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGICih1Y3gYnR6kU4&open=AZ8PGICih1Y3gYnR6kU4&pullRequest=135

Check warning on line 34 in ObjLoader/Loaders/ObjLoader/ObjLoaderFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Initialize all 'static fields' inline and remove the 'static constructor'.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGIAxh1Y3gYnR6kUz&open=AZ8PGIAxh1Y3gYnR6kUz&pullRequest=135

Check warning on line 3 in Tests/SharpEngine.Core.Numerics.Tests/Class1.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty class, write its code or make it an "interface".

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGIDZh1Y3gYnR6kVC&open=AZ8PGIDZh1Y3gYnR6kVC&pullRequest=135

Check failure on line 155 in SharpEngine.Core/Windowing/Window.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This method signature overlaps the one defined on line 107, the default parameter value can only be used with named arguments.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGIB7h1Y3gYnR6kU2&open=AZ8PGIB7h1Y3gYnR6kU2&pullRequest=135

Check failure on line 28 in Examples/MultipleWindows/Program.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Dispose '_cancellationTokenSource' when it is no longer needed.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGH9Bh1Y3gYnR6kUu&open=AZ8PGH9Bh1Y3gYnR6kUu&pullRequest=135

Check warning on line 242 in SharpEngine.Core/Handlers/WindowHandler.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter 'arg2'.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGIC-h1Y3gYnR6kU_&open=AZ8PGIC-h1Y3gYnR6kU_&pullRequest=135

Check warning on line 130 in Examples/MultipleWindows/Program.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter 'arg3'.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGH9Bh1Y3gYnR6kUx&open=AZ8PGH9Bh1Y3gYnR6kUx&pullRequest=135

Check warning on line 242 in SharpEngine.Core/Handlers/WindowHandler.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter 'args1'.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGIC-h1Y3gYnR6kU-&open=AZ8PGIC-h1Y3gYnR6kU-&pullRequest=135

Check warning on line 206 in SharpEngine.Core/Handlers/WindowHandler.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to 'MouseButton'.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGIC-h1Y3gYnR6kU8&open=AZ8PGIC-h1Y3gYnR6kU8&pullRequest=135

Check warning on line 18 in SharpEngine.Core/Windowing/SilkWindow.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGICRh1Y3gYnR6kU3&open=AZ8PGICRh1Y3gYnR6kU3&pullRequest=135

Check warning on line 3 in Tests/SharpEngine.Core.Components.Tests/Class1.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty class, write its code or make it an "interface".

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGIDPh1Y3gYnR6kVB&open=AZ8PGIDPh1Y3gYnR6kVB&pullRequest=135

Check warning on line 130 in Examples/MultipleWindows/Program.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter 'args1'.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGH9Bh1Y3gYnR6kUv&open=AZ8PGH9Bh1Y3gYnR6kUv&pullRequest=135

Check warning on line 130 in Examples/MultipleWindows/Program.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter 'arg2'.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGH9Bh1Y3gYnR6kUw&open=AZ8PGH9Bh1Y3gYnR6kUw&pullRequest=135

Check warning on line 34 in SharpEngine.Core/Renderers/ParticleRenderer.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this logger to use its enclosing type.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGICih1Y3gYnR6kU6&open=AZ8PGICih1Y3gYnR6kU6&pullRequest=135

Check warning on line 3 in SharpEngine.Core.ArchitectureTests/Class1.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty class, write its code or make it an "interface".

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGIDih1Y3gYnR6kVD&open=AZ8PGIDih1Y3gYnR6kVD&pullRequest=135

Check warning on line 242 in SharpEngine.Core/Handlers/WindowHandler.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter 'arg3'.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PGIC-h1Y3gYnR6kVA&open=AZ8PGIC-h1Y3gYnR6kVA&pullRequest=135