Skip to content

#109 Improve testability and cleanup - #135

Merged
Av3boy merged 5 commits into
devfrom
109-av-tests
Jun 28, 2026
Merged

#109 Improve testability and cleanup#135
Av3boy merged 5 commits into
devfrom
109-av-tests

Conversation

@Av3boy

@Av3boy Av3boy commented Jun 28, 2026

Copy link
Copy Markdown
Owner

#109 Improve testability and cleanup

Contents

  • Make things more testable by introducing abstration levels around the file system.
  • This PR also contains Audio related additions. NOTE: Those changes aren't related to Engine Orchestrator #109 but I am lazy and didn't want to create a separate PR.

Checklist

  • I have merged the latest changes from main to my branch.
  • I have tested my changes and any affected components.
  • I have added the proper documentation about my changes
  • I have made sure there is no overlapping work.
  • I have discussed any / all issues brought up from code review.

Av3boy added 4 commits June 12, 2026 00:40
@Av3boy
#109 Add initial unit tests
1dc3332
@Av3boy
#109 Audio player updates
c62c365 
Added pause, resume and loading new audios on top of an existing player
@Av3boy
#109 Fix windowing
bbc57ed
@Av3boy
#109 Update scene calls
d583a4a
@Av3boy Av3boy self-assigned this Jun 28, 2026
@Av3boy Av3boy added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request audio Changes related to the audio in the engine window Changes related to the windows of the engine core The issue is related to the Core library. maintainability labels Jun 28, 2026
@Av3boy
Av3boy merged commit 100155c into dev Jun 28, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 28, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Av3boy Av3boy

Labels

audio Changes related to the audio in the engine bug Something isn't working core The issue is related to the Core library. documentation Improvements or additions to documentation enhancement New feature or request maintainability window Changes related to the windows of the engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Av3boy