Skip to content

test(ios): stabilize friend nickname update coverage #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnganSamadder merged 2 commits into from
Aug 25, 2026
Merged

test(ios): stabilize friend nickname update coverage #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28d5890
test(ios): make nickname update fixture deterministic
AnganSamadder Aug 25, 2026
cf49d1e
chore(release): prepare 0.1.17
AnganSamadder Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions PayBack.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2245,7 +2245,7 @@
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 131;
CURRENT_PROJECT_VERSION = 132;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = 39YTAJZTZ6;
ENABLE_STRICT_OBJC_MSGSEND = YES;
Expand All @@ -2267,7 +2267,7 @@
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 18.0;
MARKETING_VERSION = 0.1.16;
MARKETING_VERSION = 0.1.17;
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
MTL_FAST_MATH = YES;
ONLY_ACTIVE_ARCH = YES;
Expand Down Expand Up @@ -2315,7 +2315,7 @@
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 131;
CURRENT_PROJECT_VERSION = 132;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = 39YTAJZTZ6;
ENABLE_NS_ASSERTIONS = NO;
Expand All @@ -2332,7 +2332,7 @@
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 18.0;
MARKETING_VERSION = 0.1.16;
MARKETING_VERSION = 0.1.17;
MTL_ENABLE_DEBUG_INFO = NO;
MTL_FAST_MATH = YES;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -2456,7 +2456,7 @@
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 131;
CURRENT_PROJECT_VERSION = 132;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = 39YTAJZTZ6;
ENABLE_NS_ASSERTIONS = NO;
Expand All @@ -2473,7 +2473,7 @@
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 18.0;
MARKETING_VERSION = 0.1.16;
MARKETING_VERSION = 0.1.17;
MTL_ENABLE_DEBUG_INFO = NO;
MTL_FAST_MATH = YES;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down
14 changes: 6 additions & 8 deletions apps/ios/PayBack/Tests/Services/AppStoreTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,9 +546,7 @@ final class AppStoreTests: XCTestCase {
func testUpdateFriendNickname_UpdatesNickname() async throws {
// Given
let account = UserAccount(id: "test-123", email: "test@example.com", displayName: "Example User")
_ = UserSession(account: account)
sut.completeAuthentication(id: account.id, email: account.email, name: account.displayName)
try await Task.sleep(nanoseconds: 100_000_000)
sut.session = UserSession(account: account)

let memberId = UUID()
let friend = AccountFriend(
Expand All @@ -560,15 +558,15 @@ final class AppStoreTests: XCTestCase {
linkedAccountEmail: nil
)

try await mockAccountService.syncFriends(accountEmail: account.email, friends: [friend])
sut.addGroup(name: "Test", memberNames: ["Alice"])
try await Task.sleep(nanoseconds: 200_000_000)
sut.processFriendsUpdate([friend])

// When
try await sut.updateFriendNickname(memberId: memberId, nickname: "Ally")

// Then - nickname should be updated in local state
XCTAssertTrue(true) // Test completes without error
// Then
XCTAssertEqual(sut.friends.first?.nickname, "Ally")
let syncedFriends = await mockAccountService.latestSyncedFriends(accountEmail: account.email)
XCTAssertEqual(syncedFriends?.first?.nickname, "Ally")
}

func testUpdateFriendNickname_WithoutSession_Throws() async throws {
Expand Down
4 changes: 2 additions & 2 deletions project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ settings:
base:
SWIFT_VERSION: "5.10"
IPHONEOS_DEPLOYMENT_TARGET: "18.0"
MARKETING_VERSION: 0.1.16
CURRENT_PROJECT_VERSION: 131
MARKETING_VERSION: 0.1.17
CURRENT_PROJECT_VERSION: 132
DEVELOPMENT_TEAM: "39YTAJZTZ6"
ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS: YES
ENABLE_USER_SCRIPT_SANDBOXING: NO
Expand Down
Loading