Fix a few combat and magic logic bugs - #4501
Merged
Merged
Conversation
Collaborator
|
Thanks for all the bug fixes @Y0oshi! |
gmriggs
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fellow_kt_killercheck was inverted inOnDeath_HandleKillTask(introduced in extend summoning killtask multicredit bug to fellowships, capped with new server option #3561 when the logic was inlined fromKillTask_GetEligibleReceivers). With the default (true), fellows got kill task credit even when the killer didn't have the quest, which is the opposite of the property description and the original logic. Note this changes live behavior on servers using the default.newValis the unclamped value, so costs that overdrew stamina skippedOnExhausted. Checks the clamped value instead, which is how it worked before improved RunRate handling for players #2417.EnchantmentManager.Adddidn't passisWeaponSpellwhen writing a new layer, so weapon, cloak and aetheria procs that stacked onto an existing category picked up the Archmage's Endurance duration bonus. The first-layer and refresh paths already passed it.target.Invincible, andTryResistSpellauto-resists for any invincible creature instead of only players.