Repository navigation
extend summoning killtask multicredit bug to fellowships, capped with new server option - #3561
Merged
gmriggs merged 1 commit intoJun 29, 2021
Conversation
… new server option
Mag-nus
approved these changes
Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the existing allow_summoning_killtask_multicredit bug (which defaults to true, as per retail) to fellowships, which is also per retail
What this PR does not do is allow fellowships to exploit this bug to any extreme, by default. It is theorized that in retail, it would have been possible for each person in a fellowship to possibly get 46 kill credits from a single mob, if they knew how to exploit this issue to its maximum theoretical potential.
This PR adds a new server option, summoning_killtask_multicredit_cap, which defaults to 2. This new server option technically makes the old allow_summoning_killtask_multicredit server option obsolete, however the old server option is still supported for compatibility with existing servers who may have already decided to fix this issue.
This means that someone exploiting this issue to any extremity will still only be able to get a maximum of 2 kill credits from 1 kill. Retail was theoretically uncapped here, as evidenced by some people doing solo testing with 1 summoner not involved in a fellowship being able to get 6 kill credits from 1 kill (1 personal, plus an additional 5 summons that they were able to fit into the 3-minute damage history window)
So while this technically reins in the existing solo bug from theoretically 6 max -> 2, it also extends the potential additional credit to each person in the fellowship with at least 1 summoner.
See the writeup for the original PR for additional info:
#3122
As with the original PR, this new version was extensively tested using a standalone program to simulate all of the different possible combinations and server config settings. The latest version went through a few different iterations to ensure each scenario resulted in the expected output, also similar to the original version.