Fix progression eccentric percent localization - #547
Conversation
There was a problem hiding this comment.
Code Review
This pull request localizes the "Increase eccentric load by" string and introduces a locale-aware integer percentage formatter (integerPercentLabel) to prevent glyph collisions on Italian iOS devices. It also updates the progression settings sheet to use this formatter and adjusts the layout width accordingly. The review feedback suggests making the formatter more generic by accepting Number instead of Int to support float percentages, simplifying the language matching logic using substringBefore, and updating the associated wrappers, imports, and unit tests to use the renamed generic helpers.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…ngs-eccentric-l10n # Conflicts: # shared/src/commonMain/kotlin/com/devil/phoenixproject/domain/model/EccentricLoadLabels.kt # shared/src/commonTest/kotlin/com/devil/phoenixproject/domain/model/EccentricLoadDisplayNameTest.kt
Summary
ProgressionSettingsSheetfor the eccentric progression percent value, with a 60.dp minimum width instead of the prior fixed 50.dp cell.Refs #540
Follow-up to #542 / Kanban task
t_4d68d132.Tests
git diff --checkbash .github/scripts/forbid-tracked-secrets.sh./gradlew :shared:testAndroidHostTest -Pskip.supabase.check=true --no-daemon --console=plain./gradlew :shared:compileKotlinIosArm64 :shared:compileTestKotlinIosArm64 -Pskip.supabase.check=true --no-daemon --console=plain./gradlew spotlessCheck validateSchemaManifest :shared:verifyCommonMainVitruvianDatabaseMigration -Pskip.supabase.check=true --no-daemon --console=plain(partial: schema + migration passed; Spotless failed on pre-existing unrelated files outside this PR's diff. This PR's touched Kotlin files were formatted withspotlessKotlinApply, with unrelated formatter changes reverted.)