Skip to content

Fix progression eccentric percent localization - #547

Merged
9thLevelSoftware merged 3 commits into
mainfrom
fix/progression-settings-eccentric-l10n
Jun 15, 2026
Merged

Fix progression eccentric percent localization#547
9thLevelSoftware merged 3 commits into
mainfrom
fix/progression-settings-eccentric-l10n

Conversation

@9thLevelSoftware

Copy link
Copy Markdown
Owner

Summary

  • Add a reusable locale-aware integer percent formatter for arbitrary eccentric/progression percentages.
  • Use it in ProgressionSettingsSheet for the eccentric progression percent value, with a 60.dp minimum width instead of the prior fixed 50.dp cell.
  • Move the hard-coded "Increase eccentric load by" label into Compose resources, including an Italian translation.

Refs #540
Follow-up to #542 / Kanban task t_4d68d132.

Tests

  • git diff --check
  • bash .github/scripts/forbid-tracked-secrets.sh
  • ./gradlew :shared:testAndroidHostTest -Pskip.supabase.check=true --no-daemon --console=plain
  • ./gradlew :shared:compileKotlinIosArm64 :shared:compileTestKotlinIosArm64 -Pskip.supabase.check=true --no-daemon --console=plain
  • ./gradlew spotlessCheck validateSchemaManifest :shared:verifyCommonMainVitruvianDatabaseMigration -Pskip.supabase.check=true --no-daemon --console=plain (partial: schema + migration passed; Spotless failed on pre-existing unrelated files outside this PR's diff. This PR's touched Kotlin files were formatted with spotlessKotlinApply, with unrelated formatter changes reverted.)

Copilot AI review requested due to automatic review settings June 14, 2026 04:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request localizes the "Increase eccentric load by" string and introduces a locale-aware integer percentage formatter (integerPercentLabel) to prevent glyph collisions on Italian iOS devices. It also updates the progression settings sheet to use this formatter and adjusts the layout width accordingly. The review feedback suggests making the formatter more generic by accepting Number instead of Int to support float percentages, simplifying the language matching logic using substringBefore, and updating the associated wrappers, imports, and unit tests to use the renamed generic helpers.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

…ngs-eccentric-l10n

# Conflicts:
#	shared/src/commonMain/kotlin/com/devil/phoenixproject/domain/model/EccentricLoadLabels.kt
#	shared/src/commonTest/kotlin/com/devil/phoenixproject/domain/model/EccentricLoadDisplayNameTest.kt
@9thLevelSoftware
9thLevelSoftware merged commit 290e6b2 into main Jun 15, 2026
9 checks passed
@9thLevelSoftware
9thLevelSoftware deleted the fix/progression-settings-eccentric-l10n branch June 15, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants