Repository navigation
std/crypto: add scrypt kdf - #9577
Merged
Merged
Conversation
Contributor
|
Good job, @x13a ! And happy to see that CI is now green! 🎉 I'm going to review it as soon as possible. Yescrypt is the successor to scrypt and is already used in Fedora and Debian, so we want to make sure that it can be added without breaking the API. The generic parameters should already take care of this. So only the fact that Yescrypt supports encryption might require a minor API change. Thanks again for this! |
jedisct1
added
breaking
jedisct1
reviewed
Aug 22, 2021
add phc encoding parser add password hash functions to benchmark change bcrypt to be consistent with scrypt
Contributor
|
Let's get this in! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone!
This is the second time to try to add scrypt kdf.
Previous pull: 8200
/cc @jedisct1