You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add getSentinel helper to Pointer and Array builtin.Types - #21993
hmm im having second thoughts on this asserting that its not null. a decent number of uses of sentinel_ptr are first checking if its null, as does std.meta.sentinel (which i didnt notice existed before :p but i think itd still be favorable to have something builtin like this). thoughts? yeah nevermind i think this is vastly more useful if it returns null
so if im not wrong this requires a zig1 update since it changes builtin, correct? assuming this change is deemed worth it, is the correct order of operations something like this?
commit 1. change the field in builtin.zig and sema + any uses of it
commit 2. update zig1.wasm, later to be replaced by a team member
commit 3. add the function and update any places where its useful
Sorry, I forgot about this PR! Your changes will make it in in spirit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.