Skip to content

test/standalone/emit_asm_and_bin and issue_12588 can be re-enabled now #17484

Closed
Closed
test/standalone/emit_asm_and_bin and issue_12588 can be re-enabled now#17484
Labels
bugObserved behavior contradicts documented or intended behaviorcontributor friendlyThis issue is limited in scope and/or knowledge of Zig internals.
Milestone
0.14.0

Description

@andrewrk
andrewrk
opened on Oct 11, 2023

zig/test/standalone.zig

Lines 143 to 152 in 5722261

// TODO take away EmitOption.emit_to option and make it give a FileSource
//.{
// .build_root = "test/standalone/emit_asm_and_bin",
// .import = @import("standalone/emit_asm_and_bin/build.zig"),
//},
// TODO take away EmitOption.emit_to option and make it give a FileSource
//.{
// .build_root = "test/standalone/issue_12588",
// .import = @import("standalone/issue_12588/build.zig"),
//},

These were waiting for a LazyPath reckoning, which has happened in #16446 thanks to @MasterQ32. Now these tests can be enabled.

The one called "issue_12588" should be renamed to describe what it is testing instead of named after a GitHub:tm: issue.

Activity

  1. andrewrk
    added
    bugObserved behavior contradicts documented or intended behavior
    contributor friendlyThis issue is limited in scope and/or knowledge of Zig internals.
    on Oct 11, 2023
  2. andrewrk
    added this to the 0.13.0 milestone on Oct 11, 2023
  3. maximeconnolly
    added a commit that references this issue on Oct 23, 2023

    test: ziglang#17484 reenable emit asm and bin and rename issue_12588 …

    7731c6e
  4. Parzival-3141
    added a commit that references this issue on Feb 17, 2024

    reenable tests and rename `standalone/issue_12588`

    e18b878
  5. Snektron
    added 4 commits that reference this issue on Aug 18, 2024

    re-enable emit_asm_and_bin and emit_llvm_no_bin tests

    5ae56c4

    re-enable emit_asm_and_bin and emit_llvm_no_bin tests

    db99ec3

    re-enable emit_asm_and_bin and emit_llvm_no_bin tests

    b3f638c

    re-enable emit_asm_and_bin and emit_llvm_no_bin tests

    8099939
  6. andrewrk
    closed this as completedin 8099939on Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugObserved behavior contradicts documented or intended behaviorcontributor friendlyThis issue is limited in scope and/or knowledge of Zig internals.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions