zig fmt does not handle shebang lines

This should be handled at the parser level.

#!/bin/zig

pub fn main() void {
    const a = 5;
}

$ zig2 fmt t.zig 
t.zig:1:1: error: Expected variable declaration or function, found Invalid
#!/bin/zig
~

This should be handled at the parser level.

I started looking at this, and it seemed easiest to create Token.ShebangLine. It would only show up if the first 2 bytes of the file were #!, and it could only be the first token, and would be guaranteed to only show up once total.

The parser would look at the first token and skip it if it is a shebang line, otherwise put it back and continue.

Do you think I shouldn't do it this way?

I went ahead and did it since this is better than status quo, but feel free to change the implementation if you have a better way.

This solution is good. Easy for external users when using std/zig.

Navigation Menu

Repository navigation

zig fmt does not handle shebang lines #1546

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

zig fmt does not handle shebang lines #1546

Description

Activity

andrewrk commented on Sep 18, 2018

andrewrk commented on Sep 18, 2018

tiehuis commented on Sep 19, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions