Repository navigation
Conversation
|
Updated to Includes the bundled color emoji, touch-focus tracking and browser keyboard/input fixes. Added CI coverage for Unicode deletion, touch-focus policy, emoji rendering and browser DOM focus. Local checks passed, including the real headless Firefox DOM test with the lock-matched wasm-bindgen runner. I’ve also verified the integrated behavior in the staging app. This should land before zeron #319, which will then be repinned to the resulting upstream revision. |
|
Good morning — I did an additional review sweep of the browser runtime changes before asking for another review. The sweep found one pointer-cancellation issue: browsers commonly report Both terminal paths now use the button recorded during pointer-down. This preserves the original button and prevents duplicate releases if cancellation and capture loss both fire. I also reviewed the broader runtime changes again, with particular attention to:
No additional merge-blocking issues were found. The remaining suggestions were optional browser-test hardening for complete pointer sequences and cross-browser IME event ordering. This PR should still land before zeron #319 so that the application PR can be repinned to the actual upstream zui merge SHA. |
GPUI's paste key binding matched the real keydown, so register_key_down cancelled its default and the browser never emitted the paste event. The composer's Paste action then read the stale in-memory clipboard cache. Skip GPUI dispatch and default cancellation for the plain paste chord so register_paste receives the real clipboard payload.
Mobile browsers can hide the keyboard (e.g. Android Back) without blurring the hidden input, and focus() on the already-active element never shows it again. Bounce focus through the canvas first so the tap re-opens it.
20d1c5b to
93ab2ca
Compare
Summary
Companion browser runtime changes for zeronsh/zeron#319.
Atomics.waitAsyncreturns synchronously; parse asynchronous results without confusing values and promises.f14fea9).beforeinputdeletion using grapheme-safe UTF-16 ranges and prevent browser defaults for handled keydowns.Validation
Locally executed with
nightly-2026-09-08:wasm-bindgen-test, rather than only compiling.c1700b8de27a07b5bc1a190440b64e7323c008f9; the later runtime commit only corrects CI setup.Commands:
crates/gpui_web/tests/README.md.Hosted checks: Web runtime workflow.
Remaining / landing order
zeronsh/zuirevision and rerun its locked build.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.